Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/chrome/test/chromedriver/chrome_launcher.cc

Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/chrome/common/metrics/caching_permuted_entropy_provider.cc ('k') | trunk/src/chrome/test/chromedriver/chrome_launcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/test/chromedriver/chrome_launcher.cc
===================================================================
--- trunk/src/chrome/test/chromedriver/chrome_launcher.cc (revision 239920)
+++ trunk/src/chrome/test/chromedriver/chrome_launcher.cc (working copy)
@@ -497,7 +497,8 @@
if (key_len != public_key.size())
return Status(kUnknownError, "invalid public key length");
std::string public_key_base64;
- base::Base64Encode(public_key, &public_key_base64);
+ if (!base::Base64Encode(public_key, &public_key_base64))
+ return Status(kUnknownError, "cannot base64 encode public key");
std::string id = GenerateExtensionId(public_key);
// Unzip the crx file.
« no previous file with comments | « trunk/src/chrome/common/metrics/caching_permuted_entropy_provider.cc ('k') | trunk/src/chrome/test/chromedriver/chrome_launcher_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698