trunk/src/chrome/common/metrics/caching_permuted_entropy_provider.cc - Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/chrome/common/metrics/caching_permuted_entropy_provider.cc

Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trunk/src/chrome/common/metrics/caching_permuted_entropy_provider.cc

===================================================================

--- trunk/src/chrome/common/metrics/caching_permuted_entropy_provider.cc (revision 239920)

+++ trunk/src/chrome/common/metrics/caching_permuted_entropy_provider.cc (working copy)

@@ -66,7 +66,10 @@

cache_.SerializeToString(&serialized);

std::string base64_encoded;

- base::Base64Encode(serialized, &base64_encoded);

+ if (!base::Base64Encode(serialized, &base64_encoded)) {

+ NOTREACHED();

+ return;

+ }

local_state_->SetString(prefs::kMetricsPermutedEntropyCache, base64_encoded);

}