Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/chrome/browser/ui/ash/screenshot_taker.cc

Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/chrome/browser/sync/profile_sync_service_harness.cc ('k') | trunk/src/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/browser/ui/ash/screenshot_taker.cc
===================================================================
--- trunk/src/chrome/browser/ui/ash/screenshot_taker.cc (revision 239920)
+++ trunk/src/chrome/browser/ui/ash/screenshot_taker.cc (working copy)
@@ -71,7 +71,10 @@
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
std::string encoded;
- base::Base64Encode(png_data->data(), &encoded);
+ if (!base::Base64Encode(png_data->data(), &encoded)) {
+ LOG(ERROR) << "Failed to encode base64";
+ return;
+ }
// Only cares about HTML because ChromeOS doesn't need other formats.
// TODO(dcheng): Why don't we take advantage of the ability to write bitmaps
« no previous file with comments | « trunk/src/chrome/browser/sync/profile_sync_service_harness.cc ('k') | trunk/src/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698