Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Unified Diff: trunk/src/chrome/browser/sync/profile_sync_service_harness.cc

Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/sync/profile_sync_service_harness.cc
===================================================================
--- trunk/src/chrome/browser/sync/profile_sync_service_harness.cc (revision 239920)
+++ trunk/src/chrome/browser/sync/profile_sync_service_harness.cc (working copy)
@@ -929,8 +929,13 @@
if (marker != partner_marker) {
if (VLOG_IS_ON(2)) {
std::string marker_base64, partner_marker_base64;
- base::Base64Encode(marker, &marker_base64);
- base::Base64Encode(partner_marker, &partner_marker_base64);
+ if (!base::Base64Encode(marker, &marker_base64)) {
+ NOTREACHED();
+ }
+ if (!base::Base64Encode(
+ partner_marker, &partner_marker_base64)) {
+ NOTREACHED();
+ }
DVLOG(2) << syncer::ModelTypeToString(i.Get()) << ": "
<< profile_debug_name_ << " progress marker = "
<< marker_base64 << ", "

Powered by Google App Engine
This is Rietveld 408576698