Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1011113004: CpuProfiler: log pc offset for deopts. (Closed)

Created:
5 years, 9 months ago by loislo
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne, alph, yurys
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CpuProfiler: log pc offset for deopts. This is the fifth part of https://codereview.chromium.org/1012633002 In this part we collect the offsets of deopt calls and save it into an inlined function info. On the Next: Later when deopt happens we will get the offset of deopt call and search it among inlined infos. BUG=chromium:452067 LOG=n Committed: https://crrev.com/7fef610d723b09f51573a58ae8c89ed15069488a Cr-Commit-Position: refs/heads/master@{#27258}

Patch Set 1 #

Patch Set 2 : rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M src/arm/lithium-codegen-arm.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 3 chunks +4 lines, -1 line 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
loislo
PTAL
5 years, 9 months ago (2015-03-18 07:20:31 UTC) #2
Sven Panne
LGTM. Changing PPC would be nice, too. Our general rule of thumb is: If it's ...
5 years, 9 months ago (2015-03-18 08:22:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011113004/20001
5 years, 9 months ago (2015-03-18 08:53:10 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-18 09:30:36 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 09:30:45 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7fef610d723b09f51573a58ae8c89ed15069488a
Cr-Commit-Position: refs/heads/master@{#27258}

Powered by Google App Engine
This is Rietveld 408576698