Source/bindings/core/v8/custom/V8BlobCustomHelpers.cpp - Issue 1011093002: [bindings] Pass NormalConversion to to[U]Int{8/16/32/64}(...) in v8_types.py and reduce conversion …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8BlobCustomHelpers.cpp

Issue 1011093002: [bindings] Pass NormalConversion to to[U]Int{8/16/32/64}(...) in v8_types.py and reduce conversion … (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/custom/V8BlobCustomHelpers.cpp

diff --git a/Source/bindings/core/v8/custom/V8BlobCustomHelpers.cpp b/Source/bindings/core/v8/custom/V8BlobCustomHelpers.cpp

index aece51bd40e5c1c34355ce8898613c59f1d94734..eb8f10acb373ca5b6666f67c12da18c9e89955c4 100644

--- a/Source/bindings/core/v8/custom/V8BlobCustomHelpers.cpp

+++ b/Source/bindings/core/v8/custom/V8BlobCustomHelpers.cpp

@@ -98,7 +98,8 @@ bool ParsedProperties::parseBlobPropertyBag(v8::Isolate* isolate, v8::Local<v8::

v8::Local<v8::Value> lastModified;

TONATIVE_DEFAULT(bool, containsLastModified, DictionaryHelper::get(dictionary, "lastModified", lastModified), false);

if (containsLastModified) {

- TONATIVE_DEFAULT(long long, lastModifiedInt, toInt64(isolate, lastModified), false);

+ NonThrowableExceptionState exceptionState;

haraken 2015/03/17 15:08:12 Ditto. Can we use the existing |exceptionState| ?

+ TONATIVE_DEFAULT(long long, lastModifiedInt, toInt64(isolate, lastModified, NormalConversion, exceptionState), false);

setLastModified(static_cast<double>(lastModifiedInt));

} else {

setDefaultLastModified();

« Source/bindings/core/v8/PrivateScriptRunner.cpp ('K') | « Source/bindings/core/v8/V8BindingTest.cpp ('k') | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »