Source/bindings/core/v8/PrivateScriptRunner.cpp - Issue 1011093002: [bindings] Pass NormalConversion to to[U]Int{8/16/32/64}(...) in v8_types.py and reduce conversion …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/PrivateScriptRunner.cpp

Issue 1011093002: [bindings] Pass NormalConversion to to[U]Int{8/16/32/64}(...) in v8_types.py and reduce conversion … (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/PrivateScriptRunner.cpp

diff --git a/Source/bindings/core/v8/PrivateScriptRunner.cpp b/Source/bindings/core/v8/PrivateScriptRunner.cpp

index bfac52528535af061d8d5062074962fa9f47266a..0a58d7b7bfdfaa9e1508ca4dc6d9c97d24793722 100644

--- a/Source/bindings/core/v8/PrivateScriptRunner.cpp

+++ b/Source/bindings/core/v8/PrivateScriptRunner.cpp

@@ -242,7 +242,8 @@ void rethrowExceptionInPrivateScript(v8::Isolate* isolate, v8::TryCatch& block,

RELEASE_ASSERT(!code.IsEmpty() && code->IsInt32());

ScriptState::Scope scope(scriptStateInUserScript);

ExceptionState exceptionState(errorContext, propertyName, interfaceName, scriptStateInUserScript->context()->Global(), scriptStateInUserScript->isolate());

- exceptionState.throwDOMException(toInt32(isolate, code), messageString);

+ NonThrowableExceptionState nonThrowableExceptionState;

+ exceptionState.throwDOMException(toInt32(isolate, code, NormalConversion, nonThrowableExceptionState), messageString);

haraken 2015/03/17 15:08:12 Why can't we use the |exceptionState| for toInt32?

exceptionState.throwIfNeeded();

return;

}

« no previous file with comments | « no previous file | Source/bindings/core/v8/V8Binding.h » ('j') | Source/bindings/core/v8/custom/V8BlobCustomHelpers.cpp » ('J')