Deprecate version 5 of the favicon database.

Deprecate version 5 of the favicon database.

This version has been obsolete for longer than the 2 year deprecation window.
Maintaining backwards support for this would greatly complicate schema migration
and recovery in the transition to schema version 8, which adds support for
tracking the last_requested time of a given icon bitmap.

BUG=467712
Committed: https://crrev.com/d15eecddb0dc1ae33ce162bf4173b45a10a28b9e
Cr-Commit-Position: refs/heads/master@{#322151}

[Roger McFarlane (Chromium), 2015-03-24 19:14:14]

rogerm@chromium.org changed reviewers:
+ pkotwicz@chromium.org, shess@chromium.org, sky@chromium.org

[Roger McFarlane (Chromium), 2015-03-24 19:14:14]

rogerm@chromium.org changed required reviewers:
+ pkotwicz@chromium.org

[Roger McFarlane (Chromium), 2015-03-24 19:14:14]

Hi pkotwicz@ et al,

Per your suggestion in https://codereview.chromium.org/1004373002 I've pulled
out the deprecation of the v5 favicon db schema to its own CL.

PTAL?

[Scott Hess - ex-Googler, 2015-03-24 19:28:25]

LGTM.

In case it wasn't obvious, the deprecation and recovery code is kind of ad-hoc
work-in-progress.  So things like the 2-year rule-of-thumb are completely made
up.

https://codereview.chromium.org/1010973011/diff/1/components/history/core/bro...
File components/history/core/browser/thumbnail_database.cc (right):

https://codereview.chromium.org/1010973011/diff/1/components/history/core/bro...
components/history/core/browser/thumbnail_database.cc:82: // Version 5:
e2ee8ae9/r105004 by groby@chromium.org on 2011-10-12
Mark this line (deprecated).

[pkotwicz, 2015-03-24 21:29:13]

LGTM

[sky, 2015-03-24 22:11:57]

LGTM

[Roger McFarlane (Chromium), 2015-03-24 22:26:57]

Thanks.

https://codereview.chromium.org/1010973011/diff/1/components/history/core/bro...
File components/history/core/browser/thumbnail_database.cc (right):

https://codereview.chromium.org/1010973011/diff/1/components/history/core/bro...
components/history/core/browser/thumbnail_database.cc:82: // Version 5:
e2ee8ae9/r105004 by groby@chromium.org on 2011-10-12
On 2015/03/24 19:28:25, Scott Hess wrote:
> Mark this line (deprecated).

Done.

[Roger McFarlane (Chromium), 2015-03-24 22:45:14]

The CQ bit was checked by rogerm@chromium.org

[Roger McFarlane (Chromium), 2015-03-24 22:45:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org, sky@chromium.org, shess@chromium.org
Link to the patchset: https://codereview.chromium.org/1010973011/#ps20001
(title: "update the schema comments to show V5 as deprecated")

[commit-bot: I haz the power, 2015-03-24 22:46:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1010973011/20001

[commit-bot: I haz the power, 2015-03-25 05:06:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-25 05:06:18]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Roger McFarlane (Chromium), 2015-03-25 13:33:10]

The CQ bit was checked by rogerm@chromium.org

[commit-bot: I haz the power, 2015-03-25 13:33:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1010973011/20001

[commit-bot: I haz the power, 2015-03-25 14:03:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-25 14:05:17]

Patchset 2 (id:??) landed as
https://crrev.com/d15eecddb0dc1ae33ce162bf4173b45a10a28b9e
Cr-Commit-Position: refs/heads/master@{#322151}