Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome/browser/history/thumbnail_database_unittest.cc

Issue 1010973011: Deprecate version 5 of the favicon database. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update the schema comments to show V5 as deprecated Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/history/core/browser/thumbnail_database.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/thumbnail_database_unittest.cc
diff --git a/chrome/browser/history/thumbnail_database_unittest.cc b/chrome/browser/history/thumbnail_database_unittest.cc
index 04b9a5a1266c07bcced327045856cad5d1989018..cfebd30416aa45bc3bf6f5308c7bd1303e99a548 100644
--- a/chrome/browser/history/thumbnail_database_unittest.cc
+++ b/chrome/browser/history/thumbnail_database_unittest.cc
@@ -671,34 +671,8 @@ TEST_F(ThumbnailDatabaseTest, Version5) {
ASSERT_TRUE(db.get() != NULL);
VerifyTablesAndColumns(&db->db_);
- EXPECT_TRUE(CheckPageHasIcon(db.get(),
- kPageUrl1,
- favicon_base::FAVICON,
- kIconUrl1,
- gfx::Size(),
- sizeof(kBlob1),
- kBlob1));
- EXPECT_TRUE(CheckPageHasIcon(db.get(),
- kPageUrl2,
- favicon_base::FAVICON,
- kIconUrl2,
- gfx::Size(),
- sizeof(kBlob2),
- kBlob2));
- EXPECT_TRUE(CheckPageHasIcon(db.get(),
- kPageUrl3,
- favicon_base::FAVICON,
- kIconUrl1,
- gfx::Size(),
- sizeof(kBlob1),
- kBlob1));
- EXPECT_TRUE(CheckPageHasIcon(db.get(),
- kPageUrl3,
- favicon_base::TOUCH_ICON,
- kIconUrl3,
- gfx::Size(),
- sizeof(kBlob2),
- kBlob2));
+ // Version 5 is deprecated, the data should all be gone.
+ VerifyDatabaseEmpty(&db->db_);
}
// Test loading version 6 database.
« no previous file with comments | « no previous file | components/history/core/browser/thumbnail_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698