Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1010953002: [Extensions] Add support for reporting abuse on extension uninstallation (Closed)

Created:
5 years, 9 months ago by Devlin
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Add support for reporting abuse on extension uninstallation Add capability for having a "Report abuse" checkbox on the extension uninstall dialog. Currently, don't show this until we have the field trial specifications worked out. BUG=441377 Committed: https://crrev.com/f3af70d59497812619a1058a5a6848a5c16e1236 Cr-Commit-Position: refs/heads/master@{#321512}

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -8 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_uninstall_dialog.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_uninstall_dialog.cc View 3 chunks +19 lines, -0 lines 2 comments Download
M chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm View 2 chunks +17 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc View 8 chunks +22 lines, -5 lines 0 comments Download
M extensions/common/extension_urls.h View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/common/extension_urls.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Devlin
Finnur and Avi, mind taking a look?
5 years, 9 months ago (2015-03-18 20:22:14 UTC) #3
Avi (use Gerrit)
lgtm
5 years, 9 months ago (2015-03-18 20:30:24 UTC) #4
Finnur
LGTM, one question. https://codereview.chromium.org/1010953002/diff/20001/chrome/browser/extensions/extension_uninstall_dialog.cc File chrome/browser/extensions/extension_uninstall_dialog.cc (right): https://codereview.chromium.org/1010953002/diff/20001/chrome/browser/extensions/extension_uninstall_dialog.cc#newcode133 chrome/browser/extensions/extension_uninstall_dialog.cc:133: return false; There was a concern ...
5 years, 9 months ago (2015-03-19 10:43:26 UTC) #5
Devlin
https://codereview.chromium.org/1010953002/diff/20001/chrome/browser/extensions/extension_uninstall_dialog.cc File chrome/browser/extensions/extension_uninstall_dialog.cc (right): https://codereview.chromium.org/1010953002/diff/20001/chrome/browser/extensions/extension_uninstall_dialog.cc#newcode133 chrome/browser/extensions/extension_uninstall_dialog.cc:133: return false; On 2015/03/19 10:43:26, Finnur wrote: > There ...
5 years, 9 months ago (2015-03-19 15:50:43 UTC) #6
Finnur
This is going to be an experiment, right? Could start by limiting it to logged-in ...
5 years, 9 months ago (2015-03-19 16:17:33 UTC) #7
Devlin
On 2015/03/19 16:17:33, Finnur wrote: > This is going to be an experiment, right? Could ...
5 years, 9 months ago (2015-03-19 16:22:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010953002/20001
5 years, 9 months ago (2015-03-20 02:10:35 UTC) #10
Devlin
On 2015/03/20 02:10:35, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 9 months ago (2015-03-20 02:13:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 9 months ago (2015-03-20 03:55:12 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 03:56:07 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3af70d59497812619a1058a5a6848a5c16e1236
Cr-Commit-Position: refs/heads/master@{#321512}

Powered by Google App Engine
This is Rietveld 408576698