[Extensions] Add support for reporting abuse on extension uninstallation

[Extensions] Add support for reporting abuse on extension uninstallation

Add capability for having a "Report abuse" checkbox on the extension uninstall
dialog. Currently, don't show this until we have the field trial specifications
worked out.

BUG=441377
Committed: https://crrev.com/f3af70d59497812619a1058a5a6848a5c16e1236
Cr-Commit-Position: refs/heads/master@{#321512}

[Devlin, 2015-03-16 22:38:03]

Patchset #1 (id:1) has been deleted

[Devlin, 2015-03-18 20:22:14]

rdevlin.cronin@chromium.org changed reviewers:
+ avi@chromium.org, finnur@chromium.org

[Devlin, 2015-03-18 20:22:14]

Finnur and Avi, mind taking a look?

[Avi (use Gerrit), 2015-03-18 20:30:24]

lgtm

[Finnur, 2015-03-19 10:43:26]

LGTM, one question.

https://codereview.chromium.org/1010953002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_uninstall_dialog.cc (right):

https://codereview.chromium.org/1010953002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_uninstall_dialog.cc:133: return false;
There was a concern with logged-in vs. not-logged-in. Was the resolution on that
to require non-logged-in users to log in?

[Devlin, 2015-03-19 15:50:43]

https://codereview.chromium.org/1010953002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_uninstall_dialog.cc (right):

https://codereview.chromium.org/1010953002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_uninstall_dialog.cc:133: return false;
On 2015/03/19 10:43:26, Finnur wrote:
> There was a concern with logged-in vs. not-logged-in. Was the resolution on
that
> to require non-logged-in users to log in?

I think Jake and I are hoping that we can just drop the logged-in restriction
for the site, but that would be a webstore change.  If that can't happen (maybe
there's a concern about spam reports?), I assume we still want the option for
not-logged-in users to report abuse, so we might just have to have them log in. 
I'll try and follow up in the bug.  Shouldn't block this yet, since this is just
to get the UI ready (doesn't show it at all yet).

[Finnur, 2015-03-19 16:17:33]

This is going to be an experiment, right? Could start by limiting it to
logged-in users...?

[Devlin, 2015-03-19 16:22:29]

On 2015/03/19 16:17:33, Finnur wrote:
> This is going to be an experiment, right? Could start by limiting it to
> logged-in users...?

Yep, definitely an experiment, so that might be what we do. :)  Of course, the
downside is that if we limit to only logged in users in the experiment, but not
in the release, then we don't get any feedback on the potentially-jarring flow
of "report abuse" -> google login screen, and if we restrict it to logged in
users in both cases, then we miss opportunites for abuse reports.  Let's see if
there's any chance of either losing the login restriction, or at least making
the landing page not require it (maybe request the user to login at submit, for
instance, so that it's clear what happened from the dialog?).

[Devlin, 2015-03-20 02:10:16]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2015-03-20 02:10:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1010953002/20001

[Devlin, 2015-03-20 02:13:23]

On 2015/03/20 02:10:35, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1010953002/20001

(Pushing this through, and refining from there after discussing on the bug. 
It's in an always-off state right now, so should be safe.)

[commit-bot: I haz the power, 2015-03-20 03:55:12]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2015-03-20 03:56:07]

Patchset 1 (id:??) landed as
https://crrev.com/f3af70d59497812619a1058a5a6848a5c16e1236
Cr-Commit-Position: refs/heads/master@{#321512}