Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4816)

Unified Diff: chrome/browser/extensions/extension_uninstall_dialog.cc

Issue 1010953002: [Extensions] Add support for reporting abuse on extension uninstallation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_uninstall_dialog.cc
diff --git a/chrome/browser/extensions/extension_uninstall_dialog.cc b/chrome/browser/extensions/extension_uninstall_dialog.cc
index 30c52d50ff9866243e447c9c01500ec2805af578..01bc7cda9f34eef1988616464f1b10d44b36d2ae 100644
--- a/chrome/browser/extensions/extension_uninstall_dialog.cc
+++ b/chrome/browser/extensions/extension_uninstall_dialog.cc
@@ -10,6 +10,7 @@
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/grit/generated_resources.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/image_loader.h"
@@ -17,8 +18,11 @@
#include "extensions/common/extension.h"
#include "extensions/common/extension_icon_set.h"
#include "extensions/common/extension_resource.h"
+#include "extensions/common/extension_urls.h"
#include "extensions/common/manifest_handlers/icons_handler.h"
#include "ui/base/l10n/l10n_util.h"
+#include "ui/base/page_transition_types.h"
+#include "ui/base/window_open_disposition.h"
#include "ui/gfx/image/image.h"
#include "ui/gfx/image/image_skia.h"
@@ -123,4 +127,19 @@ std::string ExtensionUninstallDialog::GetHeadingText() {
base::UTF8ToUTF16(extension_->name()));
}
+bool ExtensionUninstallDialog::ShouldShowReportAbuseCheckbox() const {
+ // TODO(devlin): Add a field trial for reporting abuse on uninstallation.
+ // See crbug.com/441377.
+ return false;
Finnur 2015/03/19 10:43:26 There was a concern with logged-in vs. not-logged-
Devlin 2015/03/19 15:50:42 I think Jake and I are hoping that we can just dro
+}
+
+void ExtensionUninstallDialog::HandleReportAbuse() {
+ chrome::NavigateParams params(
+ profile_,
+ extension_urls::GetWebstoreReportAbuseUrl(extension_->id()),
+ ui::PAGE_TRANSITION_LINK);
+ params.disposition = NEW_FOREGROUND_TAB;
+ chrome::Navigate(&params);
+}
+
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698