Expose bits of the Web Notification database in the //content API.

Expose bits of the Web Notification database in the //content API.

This CL moves the PlatformNotificationContext and the
NotificationDatabaseData classes into the //content API. Serialization
behavior for NotificationDatabaseData will remain content-private.

The primary users of this will be (1) clearing browser data, (2) UA-
triggered notification closures and (3) forced push notifications.

Design document:
  http://goo.gl/TciXVp

BUG=447628
Committed: https://crrev.com/7b79a196374a82ecdf9204df4a4e3218fb1fd4f2
Cr-Commit-Position: refs/heads/master@{#320993}

[Peter Beverloo, 2015-03-16 18:45:45]

peter@chromium.org changed reviewers:
+ avi@chromium.org, johnme@chromium.org

[Peter Beverloo, 2015-03-16 18:45:46]

+johnme for NotificationDatabaseData static members ->
NotificationDatabaseDataConversions. We don't want to export those in the
//content API.

+avi for the //content API additions. Users are mentioned in the CL description.
One further question as a note.

https://codereview.chromium.org/1010833002/diff/60001/content/public/browser/...
File content/public/browser/notification_database_data.h (right):

https://codereview.chromium.org/1010833002/diff/60001/content/public/browser/...
content/public/browser/notification_database_data.h:19: struct CONTENT_EXPORT
NotificationDatabaseData {
The //content API entry points for Web Notifications are named
"PlatformNotification*" to avoid confusion with other kinds of notifications.

Calling this "NotificationDatabaseData" obviously does not follow that pattern.
However, calling the struct PlatformNotificationDatabaseData would be too
verbose - it'd be used in fair amount of places.

Given that the struct-level comment clarifies this well, I think this could be
OK. WDYT?

[Avi (use Gerrit), 2015-03-16 22:29:50]

lgtm

https://codereview.chromium.org/1010833002/diff/60001/content/public/browser/...
File content/public/browser/notification_database_data.h (right):

https://codereview.chromium.org/1010833002/diff/60001/content/public/browser/...
content/public/browser/notification_database_data.h:19: struct CONTENT_EXPORT
NotificationDatabaseData {
On 2015/03/16 18:45:46, Peter Beverloo wrote:
> The //content API entry points for Web Notifications are named
> "PlatformNotification*" to avoid confusion with other kinds of notifications.
> 
> Calling this "NotificationDatabaseData" obviously does not follow that
pattern.
> However, calling the struct PlatformNotificationDatabaseData would be too
> verbose - it'd be used in fair amount of places.
> 
> Given that the struct-level comment clarifies this well, I think this could be
> OK. WDYT?

I'm cool with that.

[johnme, 2015-03-17 12:28:27]

lgtm with nits

https://codereview.chromium.org/1010833002/diff/60001/content/browser/notific...
File content/browser/notifications/notification_database_data_conversions.h
(right):

https://codereview.chromium.org/1010833002/diff/60001/content/browser/notific...
content/browser/notifications/notification_database_data_conversions.h:7: 
Unused

https://codereview.chromium.org/1010833002/diff/60001/content/browser/notific...
content/browser/notifications/notification_database_data_conversions.h:18: //
Returns if the serialized |input| could be deserialized successfully.
Nit: s/if/whether/ to avoid ambiguity

https://codereview.chromium.org/1010833002/diff/60001/content/browser/notific...
File content/browser/notifications/notification_message_filter.h (right):

https://codereview.chromium.org/1010833002/diff/60001/content/browser/notific...
content/browser/notifications/notification_message_filter.h:11: #include
"base/memory/ref_counted.h"
Unused

https://codereview.chromium.org/1010833002/diff/60001/content/public/browser/...
File content/public/browser/notification_database_data.h (right):

https://codereview.chromium.org/1010833002/diff/60001/content/public/browser/...
content/public/browser/notification_database_data.h:8: #include <stdint.h>
Remove

https://codereview.chromium.org/1010833002/diff/60001/content/public/browser/...
content/public/browser/notification_database_data.h:19: struct CONTENT_EXPORT
NotificationDatabaseData {
I'm not sure if you still need CONTENT_EXPORT now?

https://codereview.chromium.org/1010833002/diff/60001/content/public/browser/...
content/public/browser/notification_database_data.h:21: int64_t notification_id
= 0;
int64 (ditto below)

https://codereview.chromium.org/1010833002/diff/60001/content/public/browser/...
File content/public/browser/platform_notification_context.h (right):

https://codereview.chromium.org/1010833002/diff/60001/content/public/browser/...
content/public/browser/platform_notification_context.h:8: #include <stdint.h>
Remove

https://codereview.chromium.org/1010833002/diff/60001/content/public/browser/...
content/public/browser/platform_notification_context.h:21: // instance may only
be used on the IO thread.
s/instance may/interface may/

https://codereview.chromium.org/1010833002/diff/60001/content/public/browser/...
content/public/browser/platform_notification_context.h:31: int64_t /*
notification_id */)>;
int64 (ditto below)

[Peter Beverloo, 2015-03-17 13:55:32]

Thanks for the reviews!

https://codereview.chromium.org/1010833002/diff/60001/content/browser/notific...
File content/browser/notifications/notification_database_data_conversions.h
(right):

https://codereview.chromium.org/1010833002/diff/60001/content/browser/notific...
content/browser/notifications/notification_database_data_conversions.h:7: 
On 2015/03/17 12:28:26, johnme wrote:
> Unused

Done.

https://codereview.chromium.org/1010833002/diff/60001/content/browser/notific...
content/browser/notifications/notification_database_data_conversions.h:18: //
Returns if the serialized |input| could be deserialized successfully.
On 2015/03/17 12:28:26, johnme wrote:
> Nit: s/if/whether/ to avoid ambiguity

Done.

https://codereview.chromium.org/1010833002/diff/60001/content/browser/notific...
File content/browser/notifications/notification_message_filter.h (right):

https://codereview.chromium.org/1010833002/diff/60001/content/browser/notific...
content/browser/notifications/notification_message_filter.h:11: #include
"base/memory/ref_counted.h"
On 2015/03/17 12:28:26, johnme wrote:
> Unused

Erps, doing that in the next patch indeed :).

https://codereview.chromium.org/1010833002/diff/60001/content/public/browser/...
File content/public/browser/notification_database_data.h (right):

https://codereview.chromium.org/1010833002/diff/60001/content/public/browser/...
content/public/browser/notification_database_data.h:8: #include <stdint.h>
On 2015/03/17 12:28:27, johnme wrote:
> Remove

We use int64_t in this file.

https://codereview.chromium.org/1010833002/diff/60001/content/public/browser/...
content/public/browser/notification_database_data.h:19: struct CONTENT_EXPORT
NotificationDatabaseData {
On 2015/03/17 12:28:27, johnme wrote:
> I'm not sure if you still need CONTENT_EXPORT now?

It compiles and runs fine without it, so let's try it without :).

https://codereview.chromium.org/1010833002/diff/60001/content/public/browser/...
content/public/browser/notification_database_data.h:21: int64_t notification_id
= 0;
On 2015/03/17 12:28:27, johnme wrote:
> int64 (ditto below)

No, we use int64_t in Chromium. int64 has been deprecated, see the comment in
basictypes.h:

https://code.google.com/p/chromium/codesearch#chromium/src/base/basictypes.h

https://codereview.chromium.org/1010833002/diff/60001/content/public/browser/...
File content/public/browser/platform_notification_context.h (right):

https://codereview.chromium.org/1010833002/diff/60001/content/public/browser/...
content/public/browser/platform_notification_context.h:8: #include <stdint.h>
On 2015/03/17 12:28:27, johnme wrote:
> Remove

Dito - we use int64_t in this file.

https://codereview.chromium.org/1010833002/diff/60001/content/public/browser/...
content/public/browser/platform_notification_context.h:21: // instance may only
be used on the IO thread.
On 2015/03/17 12:28:27, johnme wrote:
> s/instance may/interface may/

Done.

https://codereview.chromium.org/1010833002/diff/60001/content/public/browser/...
content/public/browser/platform_notification_context.h:31: int64_t /*
notification_id */)>;
On 2015/03/17 12:28:27, johnme wrote:
> int64 (ditto below)

Dito - int64 is preferred, int64_t is the new way.

[Peter Beverloo, 2015-03-17 16:14:42]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2015-03-17 16:14:43]

The patchset sent to the CQ was uploaded after l-g-t-m from johnme@chromium.org,
avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1010833002/#ps80001
(title: "address comments")

[commit-bot: I haz the power, 2015-03-17 16:14:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1010833002/80001

[commit-bot: I haz the power, 2015-03-17 20:04:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-17 20:04:49]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Peter Beverloo, 2015-03-17 20:59:50]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2015-03-17 20:59:51]

The patchset sent to the CQ was uploaded after l-g-t-m from johnme@chromium.org,
avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1010833002/#ps100001
(title: "add NON_EXPORTED_BASE")

[commit-bot: I haz the power, 2015-03-17 21:01:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1010833002/100001

[commit-bot: I haz the power, 2015-03-17 22:14:16]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-03-17 22:15:10]

Patchset 6 (id:??) landed as
https://crrev.com/7b79a196374a82ecdf9204df4a4e3218fb1fd4f2
Cr-Commit-Position: refs/heads/master@{#320993}