Expose bits of the Web Notification database in the //content API.

content/public/browser/notification_database_data.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CONTENT_BROWSER_NOTIFICATIONS_NOTIFICATION_DATABASE_DATA_H_
-#define CONTENT_BROWSER_NOTIFICATIONS_NOTIFICATION_DATABASE_DATA_H_
+#ifndef CONTENT_PUBLIC_BROWSER_NOTIFICATION_DATABASE_DATA_H_
+#define CONTENT_PUBLIC_BROWSER_NOTIFICATION_DATABASE_DATA_H_
 
 #include <stdint.h>

[johnme, 2015/03/17 12:28:27]

Remove

[Peter Beverloo, 2015/03/17 13:55:31]

We use int64_t in this file.

 
 #include "content/common/content_export.h"
 #include "content/public/common/platform_notification_data.h"
 #include "url/gurl.h"
 
 namespace content {
 
 // Stores information about a Web Notification as available in the notification
 // database. Beyond the notification's own data, its id and attribution need
 // to be available for users of the database as well.
 struct CONTENT_EXPORT NotificationDatabaseData {

[Peter Beverloo, 2015/03/16 18:45:46]

The //content API entry points for Web Notifications are named
"PlatformNotification*" to avoid confusion with other kinds of notifications.

Calling this "NotificationDatabaseData" obviously does not follow that pattern.
However, calling the struct PlatformNotificationDatabaseData would be too
verbose - it'd be used in fair amount of places.

Given that the struct-level comment clarifies this well, I think this could be
OK. WDYT?

[Avi (use Gerrit), 2015/03/16 22:29:50]

I'm cool with that.

[johnme, 2015/03/17 12:28:27]

I'm not sure if you still need CONTENT_EXPORT now?

[Peter Beverloo, 2015/03/17 13:55:31]

It compiles and runs fine without it, so let's try it without :).

-  NotificationDatabaseData();
-  ~NotificationDatabaseData();
-
-  // Parses the serialized notification database data |input| into this object.
-  bool ParseFromString(const std::string& input);
-
-  // Serializes the contents of this object to |output|. Returns if the data
-  // could be serialized successfully.
-  bool SerializeToString(std::string* output) const;
-
   // Id of the notification as allocated by the NotificationDatabase.
-  int64_t notification_id;
+  int64_t notification_id = 0;

[johnme, 2015/03/17 12:28:27]

int64 (ditto below)

[Peter Beverloo, 2015/03/17 13:55:31]

No, we use int64_t in Chromium. int64 has been deprecated, see the comment in
basictypes.h:

https://code.google.com/p/chromium/codesearch#chromium/src/base/basictypes.h

 
   // Origin of the website this notification is associated with.
   GURL origin;
 
   // Id of the Service Worker registration this notification is associated with.
-  int64_t service_worker_registration_id;
+  int64_t service_worker_registration_id = 0;
 
   // Platform data of the notification that's being stored.
   PlatformNotificationData notification_data;
 };
 
 }  // namespace content
 
-#endif  // CONTENT_BROWSER_NOTIFICATIONS_NOTIFICATION_DATABASE_DATA_H_
+#endif  // CONTENT_PUBLIC_BROWSER_NOTIFICATION_DATABASE_DATA_H_