Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 1010783002: [Icons NTP] Working prototype to fetch, store, and display big icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index 9d7e88cd4d1ad66827758bb3337020523bd66c38..febff1c61c23d46e768c8ec56391d4ab8f0c6dcd 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -1386,8 +1386,15 @@ bool ChromeContentRendererClient::WillSendRequest(
if (search_box && url.SchemeIs(chrome::kChromeSearchScheme)) {
if (url.host() == chrome::kChromeUIThumbnailHost)
return search_box->GenerateThumbnailURLFromTransientURL(url, new_url);
- else if (url.host() == chrome::kChromeUIFaviconHost)
+ if (url.host() == chrome::kChromeUIFaviconHost)
return search_box->GenerateFaviconURLFromTransientURL(url, new_url);
+ if (url.host() == chrome::kChromeUIFallbackIconHost)
+ return search_box->GenerateFallbackIconURLFromTransientURL(url, new_url);
+
+ // More restrictions for big icon host, since it may return 404 and we
+ // don't want search providers to use this as signal
+ if (url.host() == chrome::kChromeUIBigIconHost)
+ return search_box->GenerateBigIconURLFromTransientURL(url, new_url);
}
return false;

Powered by Google App Engine
This is Rietveld 408576698