Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1010773003: Web MIDI: make blink a music platform (Closed)

Created:
5 years, 9 months ago by Takashi Toyoshima
Modified:
5 years, 9 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Web MIDI: make blink a music platform Now that intent to ship is LGTMed, I'd enable Web MIDI API by default. BUG=163795 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192078

Patch Set 1 #

Patch Set 2 : status=stable #

Patch Set 3 : virtual/stable/webexposed/global-... #

Patch Set 4 : requestMIDIAccess #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 2 chunks +52 lines, -0 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
Takashi Toyoshima
Can you take a look? This depends on https://codereview.chromium.org/1011833002/ since WebRuntimeFeatures::enableWebMIDI is called from chrome.
5 years, 9 months ago (2015-03-16 18:58:02 UTC) #2
tkent
Please don't remove the flag until the feature is shipped in the stable channel, update ...
5 years, 9 months ago (2015-03-16 23:38:41 UTC) #3
Takashi Toyoshima
I see. Should we also continue to have a chromium flag, --enable-web-midi, until it is ...
5 years, 9 months ago (2015-03-17 03:19:33 UTC) #4
tkent
lgtm On 2015/03/17 03:19:33, Takashi Toyoshima (chromium) wrote: > I see. Should we also continue ...
5 years, 9 months ago (2015-03-17 03:21:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010773003/20001
5 years, 9 months ago (2015-03-17 03:22:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/52592)
5 years, 9 months ago (2015-03-17 11:56:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010773003/20001
5 years, 9 months ago (2015-03-17 19:35:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/52758)
5 years, 9 months ago (2015-03-18 03:45:17 UTC) #13
Takashi Toyoshima
Ah, that's real failures because of that my change forgot to update global-interface-listing-expected.txt for stable ...
5 years, 9 months ago (2015-03-18 04:58:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010773003/40001
5 years, 9 months ago (2015-03-18 04:59:10 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010773003/60001
5 years, 9 months ago (2015-03-18 07:54:46 UTC) #20
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 11:00:22 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192078

Powered by Google App Engine
This is Rietveld 408576698