content/browser/media/webrtc_internals.h - Issue 101063003: Add browser test for AEC dump.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/webrtc_internals.h

Issue 101063003: Add browser test for AEC dump. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added another test. Code changes to avoid race. Allow enable dump after PCF creation. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/media/webrtc_internals.h

diff --git a/content/browser/media/webrtc_internals.h b/content/browser/media/webrtc_internals.h

index fcafe657c82079c413ef573e217bbf2f0b169d30..32a46079a7932dc6bce45938fab434952a5fa535 100644

--- a/content/browser/media/webrtc_internals.h

+++ b/content/browser/media/webrtc_internals.h

@@ -5,6 +5,7 @@

#ifndef CONTENT_BROWSER_MEDIA_WEBRTC_INTERNALS_H_

#define CONTENT_BROWSER_MEDIA_WEBRTC_INTERNALS_H_

+#include "base/gtest_prod_util.h"

#include "base/memory/singleton.h"

#include "base/observer_list.h"

#include "base/process/process.h"

@@ -86,6 +87,8 @@ class CONTENT_EXPORT WebRTCInternals : public BrowserChildProcessObserver,

private:

friend struct DefaultSingletonTraits<WebRTCInternals>;

+ FRIEND_TEST_ALL_PREFIXES(WebrtcBrowserTest, CallWithAecDump);

+ FRIEND_TEST_ALL_PREFIXES(WebrtcBrowserTest, CallWithAecDumpEnabledThenDisabled);

phoglund_chromium 2013/12/18 14:20:46 Nit: line length

Henrik Grunell 2013/12/19 08:43:14 Done.

WebRTCInternals();

virtual ~WebRTCInternals();