Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: content/browser/media/webrtc_internals.h

Issue 101063003: Add browser test for AEC dump. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added another test. Code changes to avoid race. Allow enable dump after PCF creation. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_MEDIA_WEBRTC_INTERNALS_H_ 5 #ifndef CONTENT_BROWSER_MEDIA_WEBRTC_INTERNALS_H_
6 #define CONTENT_BROWSER_MEDIA_WEBRTC_INTERNALS_H_ 6 #define CONTENT_BROWSER_MEDIA_WEBRTC_INTERNALS_H_
7 7
8 #include "base/gtest_prod_util.h"
8 #include "base/memory/singleton.h" 9 #include "base/memory/singleton.h"
9 #include "base/observer_list.h" 10 #include "base/observer_list.h"
10 #include "base/process/process.h" 11 #include "base/process/process.h"
11 #include "base/values.h" 12 #include "base/values.h"
12 #include "content/common/content_export.h" 13 #include "content/common/content_export.h"
13 #include "content/public/browser/browser_child_process_observer.h" 14 #include "content/public/browser/browser_child_process_observer.h"
14 #include "content/public/browser/notification_observer.h" 15 #include "content/public/browser/notification_observer.h"
15 #include "content/public/browser/notification_registrar.h" 16 #include "content/public/browser/notification_registrar.h"
16 #include "ui/shell_dialogs/select_file_dialog.h" 17 #include "ui/shell_dialogs/select_file_dialog.h"
17 18
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 bool aec_dump_enabled() { 80 bool aec_dump_enabled() {
80 return aec_dump_enabled_; 81 return aec_dump_enabled_;
81 } 82 }
82 83
83 base::FilePath aec_dump_file_path() { 84 base::FilePath aec_dump_file_path() {
84 return aec_dump_file_path_; 85 return aec_dump_file_path_;
85 } 86 }
86 87
87 private: 88 private:
88 friend struct DefaultSingletonTraits<WebRTCInternals>; 89 friend struct DefaultSingletonTraits<WebRTCInternals>;
90 FRIEND_TEST_ALL_PREFIXES(WebrtcBrowserTest, CallWithAecDump);
91 FRIEND_TEST_ALL_PREFIXES(WebrtcBrowserTest, CallWithAecDumpEnabledThenDisabled );
phoglund_chromium 2013/12/18 14:20:46 Nit: line length
Henrik Grunell 2013/12/19 08:43:14 Done.
89 92
90 WebRTCInternals(); 93 WebRTCInternals();
91 virtual ~WebRTCInternals(); 94 virtual ~WebRTCInternals();
92 95
93 void SendUpdate(const std::string& command, base::Value* value); 96 void SendUpdate(const std::string& command, base::Value* value);
94 97
95 // BrowserChildProcessObserver implementation. 98 // BrowserChildProcessObserver implementation.
96 virtual void BrowserChildProcessCrashed( 99 virtual void BrowserChildProcessCrashed(
97 const ChildProcessData& data) OVERRIDE; 100 const ChildProcessData& data) OVERRIDE;
98 101
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 scoped_refptr<ui::SelectFileDialog> select_file_dialog_; 138 scoped_refptr<ui::SelectFileDialog> select_file_dialog_;
136 139
137 // AEC dump (diagnostic echo canceller recording) state. 140 // AEC dump (diagnostic echo canceller recording) state.
138 bool aec_dump_enabled_; 141 bool aec_dump_enabled_;
139 base::FilePath aec_dump_file_path_; 142 base::FilePath aec_dump_file_path_;
140 }; 143 };
141 144
142 } // namespace content 145 } // namespace content
143 146
144 #endif // CONTENT_BROWSER_MEDIA_WEBRTC_INTERNALS_H_ 147 #endif // CONTENT_BROWSER_MEDIA_WEBRTC_INTERNALS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698