Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(54)

Issue 1010603003: Cherrypick post upload hook changes in PRESUBMIT.py of m40 branch (Closed)

Created:
4 years, 2 months ago by rmistry
Modified:
4 years, 2 months ago
Reviewers:
borenet
CC:
reviews_skia.org, hcm
Base URL:
https://skia.googlesource.com/skia@m40
Target Ref:
refs/heads/chrome/m40
Project:
skia
Visibility:
Public.

Description

Cherrypick post upload hook changes in PRESUBMIT.py of m40 branch CLs uploaded from this branch will now automatically contain 'NOTRY=true' and 'NOTREECHECKS=true'. These CLs are cherrypicked: https://codereview.chromium.org/960203002/ ('Automatically add a docs preview link and NOTRY=true when there are only docs changes') https://codereview.chromium.org/963553002/ ('Automatically add NOTREECHECKS when uploading CLs from non master branches') BUG=skia: NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/c7917d53f9ffe1e9ecb1fae796bd670339d5fb45

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -0 lines) Patch
M PRESUBMIT.py View 3 chunks +84 lines, -0 lines 0 comments Download
M codereview.settings View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmistry
4 years, 2 months ago (2015-03-16 12:44:38 UTC) #2
borenet
LGTM
4 years, 2 months ago (2015-03-16 12:46:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010603003/1
4 years, 2 months ago (2015-03-16 12:47:07 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2015-03-16 12:47:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c7917d53f9ffe1e9ecb1fae796bd670339d5fb45

Powered by Google App Engine
This is Rietveld 408576698