Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1010443003: Make the lifetime of wallpaper manager more clear. (Closed)

Created:
5 years, 9 months ago by xdai1
Modified:
5 years, 9 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the lifetime of wallpaper manager more clear. g_wallpaper_manager was never destroyed before the fix. It should explicitly be destroyed. BUG=171694 Committed: https://crrev.com/d05f51c66370defa7ad2ed3e756a35bdbf727210 Cr-Commit-Position: refs/heads/master@{#321800}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Oshima's comments. #

Total comments: 1

Patch Set 3 : Address Biao's review comment. #

Patch Set 4 : Fix the failed unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -63 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager_unittest.cc View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h View 1 2 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc View 1 2 3 5 chunks +54 lines, -51 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_unittest.cc View 1 2 3 1 chunk +9 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 1 2 3 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 2 3 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos_unittest.cc View 1 2 3 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M components/wallpaper/wallpaper_manager_base.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
xdai1
Could you help to review the code please? Thanks!
5 years, 9 months ago (2015-03-13 21:04:09 UTC) #2
oshima
https://codereview.chromium.org/1010443003/diff/1/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc File chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc (right): https://codereview.chromium.org/1010443003/diff/1/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc#newcode274 chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc:274: static WallpaperManager* g_wallpaper_manager = NULL; move this to anonymous ...
5 years, 9 months ago (2015-03-13 22:16:41 UTC) #3
xdai1
On 2015/03/13 22:16:41, oshima wrote: > https://codereview.chromium.org/1010443003/diff/1/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc > File chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc (right): > > https://codereview.chromium.org/1010443003/diff/1/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc#newcode274 > ...
5 years, 9 months ago (2015-03-16 18:18:43 UTC) #6
bshe
https://codereview.chromium.org/1010443003/diff/60001/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc File chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc (right): https://codereview.chromium.org/1010443003/diff/60001/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc#newcode279 chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc:279: show_user_name_on_signin_subscription_.reset(); It looks like this reset call make the ...
5 years, 9 months ago (2015-03-16 18:45:40 UTC) #7
xdai1
On 2015/03/16 18:45:40, bshe wrote: > https://codereview.chromium.org/1010443003/diff/60001/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc > File chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc (right): > > https://codereview.chromium.org/1010443003/diff/60001/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc#newcode279 > ...
5 years, 9 months ago (2015-03-16 18:51:38 UTC) #8
bshe
lgtm
5 years, 9 months ago (2015-03-16 18:58:53 UTC) #9
oshima
lgtm
5 years, 9 months ago (2015-03-17 21:37:32 UTC) #10
xdai1
skuhne@, could you help to review the unit test files under chrome/browser/profiles && chrome/browser/ui/ash? Thanks ...
5 years, 9 months ago (2015-03-20 23:51:09 UTC) #12
Mr4D (OOO till 08-26)
Unit test files lgtm.
5 years, 9 months ago (2015-03-21 19:42:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010443003/100001
5 years, 9 months ago (2015-03-23 17:17:26 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 9 months ago (2015-03-23 17:21:42 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 17:22:11 UTC) #18
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/d05f51c66370defa7ad2ed3e756a35bdbf727210
Cr-Commit-Position: refs/heads/master@{#321800}

Powered by Google App Engine
This is Rietveld 408576698