Make the lifetime of wallpaper manager more clear.

chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h"
 
 #include <numeric>
 #include <vector>
 
 #include "ash/ash_constants.h"
@@ skipping 46 matching lines @@
 using content::BrowserThread;
 using wallpaper::WallpaperManagerBase;
 using wallpaper::WallpaperInfo;
 using wallpaper::MovableOnDestroyCallback;
 using wallpaper::MovableOnDestroyCallbackHolder;
 
 namespace chromeos {
 
 namespace {
 
+WallpaperManager* wallpaper_manager = nullptr;
+
 // The amount of delay before starts to move custom wallpapers to the new place.
 const int kMoveCustomWallpaperDelaySeconds = 30;
 
 const int kCacheWallpaperDelayMs = 500;
 
 // Names of nodes with info about wallpaper in |kUserWallpapersProperties|
 // dictionary.
 const char kNewWallpaperDateNodeName[] = "date";
 const char kNewWallpaperLayoutNodeName[] = "layout";
 const char kNewWallpaperLocationNodeName[] = "file";
@@ skipping 187 matching lines @@
   // image will be loaded.
   wallpaper::MovableOnDestroyCallbackHolder on_finish_;
   base::OneShotTimer<WallpaperManager::PendingWallpaper> timer;
 
   // Load start time to calculate duration.
   base::Time started_load_at_;
 
   DISALLOW_COPY_AND_ASSIGN(PendingWallpaper);
 };
 
-static WallpaperManager* g_wallpaper_manager = NULL;
-
 // WallpaperManager, public: ---------------------------------------------------
 
-// static
-WallpaperManager* WallpaperManager::Get() {
-  if (!g_wallpaper_manager)
-    g_wallpaper_manager = new WallpaperManager();
-  return g_wallpaper_manager;
-}
-
-WallpaperManager::WallpaperManager()
-    : pending_inactive_(NULL), weak_factory_(this) {
-  wallpaper::WallpaperManagerBase::SetPathIds(
-      chrome::DIR_USER_DATA,
-      chrome::DIR_CHROMEOS_WALLPAPERS,
-      chrome::DIR_CHROMEOS_CUSTOM_WALLPAPERS);
-  SetDefaultWallpaperPathsFromCommandLine(
-      base::CommandLine::ForCurrentProcess());
-  registrar_.Add(this,
-                 chrome::NOTIFICATION_LOGIN_USER_CHANGED,
-                 content::NotificationService::AllSources());
-  registrar_.Add(this,
-                 chrome::NOTIFICATION_LOGIN_OR_LOCK_WEBUI_VISIBLE,
-                 content::NotificationService::AllSources());
-  registrar_.Add(this,
-                 chrome::NOTIFICATION_WALLPAPER_ANIMATION_FINISHED,
-                 content::NotificationService::AllSources());
-  sequence_token_ = BrowserThread::GetBlockingPool()->GetNamedSequenceToken(
-      wallpaper::kWallpaperSequenceTokenName);
-  task_runner_ = BrowserThread::GetBlockingPool()->
-      GetSequencedTaskRunnerWithShutdownBehavior(
-          sequence_token_,
-          base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN);
-  wallpaper_loader_ = new UserImageLoader(ImageDecoder::ROBUST_JPEG_CODEC,
-                                          task_runner_);
-
-  user_manager::UserManager::Get()->AddSessionStateObserver(this);
-}
-
 WallpaperManager::~WallpaperManager() {
-  // TODO(bshe): Lifetime of WallpaperManager needs more consideration.
-  // http://crbug.com/171694
+  show_user_name_on_signin_subscription_.reset();

[bshe, 2015/03/16 18:45:40]

It looks like this reset call make the following DCHECK always true. Do we still
need the DCHECK?

   DCHECK(!show_user_name_on_signin_subscription_);
 
   user_manager::UserManager::Get()->RemoveSessionStateObserver(this);
 
   ClearObsoleteWallpaperPrefs();
   weak_factory_.InvalidateWeakPtrs();
 }
 
+// static
+void WallpaperManager::Initialize() {
+  CHECK(!wallpaper_manager);
+  wallpaper_manager = new WallpaperManager();
+}
+
+// static
+WallpaperManager* WallpaperManager::Get() {
+  DCHECK(wallpaper_manager);
+  return wallpaper_manager;
+}
+
+// static
+void WallpaperManager::Shutdown() {
+  CHECK(wallpaper_manager);
+  delete wallpaper_manager;
+  wallpaper_manager = nullptr;
+}
+
 WallpaperManager::WallpaperResolution
 WallpaperManager::GetAppropriateResolution() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   gfx::Size size =
       ash::DesktopBackgroundController::GetMaxDisplaySizeInNative();
   return (size.width() > wallpaper::kSmallWallpaperMaxWidth ||
           size.height() > wallpaper::kSmallWallpaperMaxHeight)
              ? WALLPAPER_RESOLUTION_LARGE
              : WALLPAPER_RESOLUTION_SMALL;
 }
 
-void WallpaperManager::Shutdown() {
-  show_user_name_on_signin_subscription_.reset();
-}
-
 void WallpaperManager::AddObservers() {
   show_user_name_on_signin_subscription_ =
       CrosSettings::Get()->AddSettingsObserver(
           kAccountsPrefShowUserNamesOnSignIn,
           base::Bind(&WallpaperManager::InitializeRegisteredDeviceWallpaper,
                      weak_factory_.GetWeakPtr()));
 }
 
 void WallpaperManager::EnsureLoggedInUserWallpaperLoaded() {
   // Some browser tests do not have a shell instance. As no wallpaper is needed
@@ skipping 389 matching lines @@
 
   if (update_wallpaper) {
     GetPendingWallpaper(last_selected_user_, false /* Not delayed */)
         ->ResetSetWallpaperImage(image, info);
   }
 }
 
 
 // WallpaperManager, private: --------------------------------------------------
 
+WallpaperManager::WallpaperManager()
+    : pending_inactive_(NULL), weak_factory_(this) {
+  wallpaper::WallpaperManagerBase::SetPathIds(
+      chrome::DIR_USER_DATA, chrome::DIR_CHROMEOS_WALLPAPERS,
+      chrome::DIR_CHROMEOS_CUSTOM_WALLPAPERS);
+  SetDefaultWallpaperPathsFromCommandLine(
+      base::CommandLine::ForCurrentProcess());
+  registrar_.Add(this, chrome::NOTIFICATION_LOGIN_USER_CHANGED,
+                 content::NotificationService::AllSources());
+  registrar_.Add(this, chrome::NOTIFICATION_LOGIN_OR_LOCK_WEBUI_VISIBLE,
+                 content::NotificationService::AllSources());
+  registrar_.Add(this, chrome::NOTIFICATION_WALLPAPER_ANIMATION_FINISHED,
+                 content::NotificationService::AllSources());
+  sequence_token_ = BrowserThread::GetBlockingPool()->GetNamedSequenceToken(
+      wallpaper::kWallpaperSequenceTokenName);
+  task_runner_ =
+      BrowserThread::GetBlockingPool()
+          ->GetSequencedTaskRunnerWithShutdownBehavior(
+              sequence_token_, base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN);
+  wallpaper_loader_ =
+      new UserImageLoader(ImageDecoder::ROBUST_JPEG_CODEC, task_runner_);
+
+  user_manager::UserManager::Get()->AddSessionStateObserver(this);
+}
+
 WallpaperManager::PendingWallpaper* WallpaperManager::GetPendingWallpaper(
     const std::string& user_id,
     bool delayed) {
   if (!pending_inactive_) {
     loading_.push_back(new WallpaperManager::PendingWallpaper(
         (delayed ? GetWallpaperLoadDelay()
                  : base::TimeDelta::FromMilliseconds(0)),
         user_id));
     pending_inactive_ = loading_.back().get();
   }
@@ skipping 281 matching lines @@
     }
   }
 
   if (need_update_screen) {
     DoSetDefaultWallpaper(std::string(),
                           MovableOnDestroyCallbackHolder().Pass());
   }
 }
 
 }  // namespace chromeos