Issue 1010433009: Use a thread pool for the CopyToPipe jobs in oknet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1010433009: Use a thread pool for the CopyToPipe jobs in oknet (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
rafaelw

CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Use a thread pool for the CopyToPipe jobs in oknet Rather than use a separate thread for every CopyToPipe job, we no use a thread pool. It's not clear from the trace whether this is much faster, but it makes the trace look much prettier. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/56d9b060511aa14058445da9f9388f5b0139a2df

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -7 lines)			Patch
	M	sky/services/oknet/src/org/domokit/oknet/NetworkServiceImpl.java	View		3 chunks	+7 lines, -1 line	0 comments	Download
	M	sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java	View		4 chunks	+16 lines, -6 lines	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

5 years, 9 months ago (2015-03-25 17:44:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
56d9b060511aa14058445da9f9388f5b0139a2df (presubmit successful).