Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: sky/services/oknet/src/org/domokit/oknet/NetworkServiceImpl.java

Issue 1010433009: Use a thread pool for the CopyToPipe jobs in oknet (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/services/oknet/src/org/domokit/oknet/NetworkServiceImpl.java
diff --git a/sky/services/oknet/src/org/domokit/oknet/NetworkServiceImpl.java b/sky/services/oknet/src/org/domokit/oknet/NetworkServiceImpl.java
index 57946573b54bc6041fa6819cf3e7b263ddbb721f..f8b5b73d58bc021491e501d323e10a894dab85e2 100644
--- a/sky/services/oknet/src/org/domokit/oknet/NetworkServiceImpl.java
+++ b/sky/services/oknet/src/org/domokit/oknet/NetworkServiceImpl.java
@@ -26,12 +26,15 @@ import org.chromium.mojom.mojo.WebSocket;
import java.io.File;
import java.io.IOException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
/**
* OkHttp implementation of NetworkService.
*/
public class NetworkServiceImpl implements NetworkService {
private static final String TAG = "NetworkServiceImpl";
+ private static ExecutorService sThreadPool;
private static OkHttpClient sClient;
private Core mCore;
@@ -39,6 +42,9 @@ public class NetworkServiceImpl implements NetworkService {
assert core != null;
mCore = core;
+ if (sThreadPool == null)
+ sThreadPool = Executors.newCachedThreadPool();
+
if (sClient == null) {
sClient = new OkHttpClient();
@@ -63,7 +69,7 @@ public class NetworkServiceImpl implements NetworkService {
@Override
public void createUrlLoader(InterfaceRequest<UrlLoader> loader) {
- UrlLoader.MANAGER.bind(new UrlLoaderImpl(mCore, sClient), loader);
+ UrlLoader.MANAGER.bind(new UrlLoaderImpl(mCore, sClient, sThreadPool), loader);
}
@Override
« no previous file with comments | « no previous file | sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698