Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2316)

Unified Diff: Source/modules/mediastream/RTCVoidRequestImpl.cpp

Issue 1010393002: Fix issue of localDescription and remoteDescription getter. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add m_pendingLocalDescription. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/mediastream/RTCVoidRequestImpl.cpp
diff --git a/Source/modules/mediastream/RTCVoidRequestImpl.cpp b/Source/modules/mediastream/RTCVoidRequestImpl.cpp
index cfde690ae9e9f1c023e2531a64e4084fc4396ebd..0dbcb32b010997a72f306e83887ddf3d91f6a7ab 100644
--- a/Source/modules/mediastream/RTCVoidRequestImpl.cpp
+++ b/Source/modules/mediastream/RTCVoidRequestImpl.cpp
@@ -60,6 +60,8 @@ RTCVoidRequestImpl::~RTCVoidRequestImpl()
void RTCVoidRequestImpl::requestSucceeded()
{
bool shouldFireCallback = m_requester ? m_requester->shouldFireDefaultCallbacks() : false;
+ m_requester->updateLocalSessionDescriptionIfNeeded(true);
Jens Widell 2015/05/05 06:31:20 To be completely correct, I think you should keep
changbin 2015/05/05 07:02:29 I see. Then how about add argument |request_type|
Jens Widell 2015/05/05 07:17:22 Something like that, yes. But then it might actual
changbin 2015/05/05 07:32:19 Yeah, that could be another option. But I'm afraid
+ m_requester->updateRemoteSessionDescriptionIfNeeded(true);
if (shouldFireCallback && m_successCallback)
m_successCallback->handleEvent();

Powered by Google App Engine
This is Rietveld 408576698