Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: Source/modules/mediastream/RTCVoidRequestImpl.cpp

Issue 1010393002: Fix issue of localDescription and remoteDescription getter. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add m_pendingLocalDescription. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 ASSERT(m_requester); 53 ASSERT(m_requester);
54 } 54 }
55 55
56 RTCVoidRequestImpl::~RTCVoidRequestImpl() 56 RTCVoidRequestImpl::~RTCVoidRequestImpl()
57 { 57 {
58 } 58 }
59 59
60 void RTCVoidRequestImpl::requestSucceeded() 60 void RTCVoidRequestImpl::requestSucceeded()
61 { 61 {
62 bool shouldFireCallback = m_requester ? m_requester->shouldFireDefaultCallba cks() : false; 62 bool shouldFireCallback = m_requester ? m_requester->shouldFireDefaultCallba cks() : false;
63 m_requester->updateLocalSessionDescriptionIfNeeded(true);
Jens Widell 2015/05/05 06:31:20 To be completely correct, I think you should keep
changbin 2015/05/05 07:02:29 I see. Then how about add argument |request_type|
Jens Widell 2015/05/05 07:17:22 Something like that, yes. But then it might actual
changbin 2015/05/05 07:32:19 Yeah, that could be another option. But I'm afraid
64 m_requester->updateRemoteSessionDescriptionIfNeeded(true);
63 if (shouldFireCallback && m_successCallback) 65 if (shouldFireCallback && m_successCallback)
64 m_successCallback->handleEvent(); 66 m_successCallback->handleEvent();
65 67
66 clear(); 68 clear();
67 } 69 }
68 70
69 void RTCVoidRequestImpl::requestFailed(const String& error) 71 void RTCVoidRequestImpl::requestFailed(const String& error)
70 { 72 {
71 bool shouldFireCallback = m_requester ? m_requester->shouldFireDefaultCallba cks() : false; 73 bool shouldFireCallback = m_requester ? m_requester->shouldFireDefaultCallba cks() : false;
72 if (shouldFireCallback && m_errorCallback.get()) 74 if (shouldFireCallback && m_errorCallback.get())
(...skipping 17 matching lines...) Expand all
90 DEFINE_TRACE(RTCVoidRequestImpl) 92 DEFINE_TRACE(RTCVoidRequestImpl)
91 { 93 {
92 visitor->trace(m_successCallback); 94 visitor->trace(m_successCallback);
93 visitor->trace(m_errorCallback); 95 visitor->trace(m_errorCallback);
94 visitor->trace(m_requester); 96 visitor->trace(m_requester);
95 RTCVoidRequest::trace(visitor); 97 RTCVoidRequest::trace(visitor);
96 ActiveDOMObject::trace(visitor); 98 ActiveDOMObject::trace(visitor);
97 } 99 }
98 100
99 } // namespace blink 101 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698