Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 101026: Change chrome-ui to chrome. I didn't go too far in converting existing string... (Closed)

Created:
11 years, 7 months ago by Glen Murphy
Modified:
9 years, 5 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Change chrome-ui to chrome. I didn't go too far in converting existing strings to using the url_constant (shipshipship). Users (such as those on Beta and Dev using session restore) attempting to load the old pages will see a blank white screen. BUG=11272 TEST=Verify that the inspector, debugger, history, downloads and newtab pages load with chrome:// URLS. Verify that replacing the chrome:// with chrome-ui:// does not work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15378

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -70 lines) Patch
M chrome/browser/browser_about_handler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/browser_main.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_url_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/debugger/debugger_view.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/debugger/devtools_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/chrome_url_data_manager.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/downloads_ui.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/history_ui.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extensions_ui.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/renderer_security_policy.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/renderer_security_policy_unittest.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/downloads.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/history.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/new_tab.html View 1 2 11 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/web_contents_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/url_pattern.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/url_pattern_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/url_constants.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/url_constants.cc View 1 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/renderer/render_thread.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_view_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/renderer_glue.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Glen Murphy
Most of the changes are comments.
11 years, 7 months ago (2009-05-04 23:32:31 UTC) #1
darin (slow to review)
LGTM It would be nice to bulk rename kChromeUIScheme* to kChromeScheme*
11 years, 7 months ago (2009-05-05 21:02:45 UTC) #2
Dean McNamee
11 years, 7 months ago (2009-05-06 08:34:55 UTC) #3
Every time we do this we break file:// entries in new tab.  Does it still work?

On 2009/05/05 21:02:45, darin wrote:
> LGTM
> 
> It would be nice to bulk rename kChromeUIScheme* to kChromeScheme*

Powered by Google App Engine
This is Rietveld 408576698