chrome/common/extensions/url_pattern_unittest.cc - Issue 101026: Change chrome-ui to chrome. I didn't go too far in converting existing string...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/url_pattern_unittest.cc

Issue 101026: Change chrome-ui to chrome. I didn't go too far in converting existing string... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/url_pattern_unittest.cc

===================================================================

--- chrome/common/extensions/url_pattern_unittest.cc (revision 15342)

+++ chrome/common/extensions/url_pattern_unittest.cc (working copy)

@@ -70,13 +70,13 @@

// odd schemes and normalization

TEST(URLPatternTest, Match4) {

URLPattern pattern;

- EXPECT_TRUE(pattern.Parse("chrome-ui://thinger/*"));

- EXPECT_EQ("chrome-ui", pattern.scheme());

+ EXPECT_TRUE(pattern.Parse("chrome://thinger/*"));

+ EXPECT_EQ("chrome", pattern.scheme());

EXPECT_EQ("thinger", pattern.host());

EXPECT_FALSE(pattern.match_subdomains());

EXPECT_EQ("/*", pattern.path());

- EXPECT_TRUE(pattern.MatchesUrl(GURL("chrome-ui://thinger/foobar")));

- EXPECT_TRUE(pattern.MatchesUrl(GURL("CHROME-UI://thinger/")));

+ EXPECT_TRUE(pattern.MatchesUrl(GURL("chrome://thinger/foobar")));

+ EXPECT_TRUE(pattern.MatchesUrl(GURL("CHROME://thinger/")));

EXPECT_FALSE(pattern.MatchesUrl(GURL("http://thinger/")));

}

« no previous file with comments | « chrome/common/extensions/url_pattern.h ('k') | chrome/common/url_constants.h » ('j') | no next file with comments »