Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1009973005: Omnibox: Fix Scoring Bugs in URLs from History (Closed)

Created:
5 years, 9 months ago by Mark P
Modified:
5 years, 9 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Omnibox: Fix Scoring Bugs in URLs from History In particular, these two bugs both affect how HistoryQuick provider suggestions are scored. One has a tendency to prevent typed visits to URL from actually being counted as typed visits. The other has a tendency to make URLs with multiple visits be suggested more aggressively than I intended. BUG=369989 Committed: https://crrev.com/cf6f1156dfe4ac64341273431728106e4c89978c Cr-Commit-Position: refs/heads/master@{#321241}

Patch Set 1 #

Patch Set 2 : now with field trial #

Total comments: 1

Patch Set 3 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -34 lines) Patch
M chrome/browser/autocomplete/scored_history_match.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/scored_history_match.cc View 1 2 3 chunks +9 lines, -3 lines 0 comments Download
M components/omnibox/omnibox_field_trial.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M components/omnibox/omnibox_field_trial.cc View 1 3 chunks +39 lines, -31 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Mark P
Peter, please take a look. thanks, mark https://codereview.chromium.org/1009973005/diff/20001/components/omnibox/omnibox_field_trial.cc File components/omnibox/omnibox_field_trial.cc (left): https://codereview.chromium.org/1009973005/diff/20001/components/omnibox/omnibox_field_trial.cc#oldcode292 components/omnibox/omnibox_field_trial.cc:292: bool OmniboxFieldTrial::HQPExperimentalScoringEnabled() ...
5 years, 9 months ago (2015-03-18 22:04:43 UTC) #2
Peter Kasting
LGTM
5 years, 9 months ago (2015-03-18 22:26:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009973005/20001
5 years, 9 months ago (2015-03-18 22:44:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009973005/40001
5 years, 9 months ago (2015-03-18 23:05:29 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-19 00:01:52 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 00:02:20 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cf6f1156dfe4ac64341273431728106e4c89978c
Cr-Commit-Position: refs/heads/master@{#321241}

Powered by Google App Engine
This is Rietveld 408576698