Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1317)

Unified Diff: components/omnibox/omnibox_field_trial.cc

Issue 1009973005: Omnibox: Fix Scoring Bugs in URLs from History (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix typo Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/omnibox/omnibox_field_trial.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/omnibox/omnibox_field_trial.cc
diff --git a/components/omnibox/omnibox_field_trial.cc b/components/omnibox/omnibox_field_trial.cc
index 6dd2302fdebd84b8dccd7a6f3b0c93f87387ec8a..ccc933c3e71d23361ce0d78d2d4536331fcb3474 100644
--- a/components/omnibox/omnibox_field_trial.cc
+++ b/components/omnibox/omnibox_field_trial.cc
@@ -289,37 +289,6 @@ int OmniboxFieldTrial::HQPBookmarkValue() {
return bookmark_value;
}
-bool OmniboxFieldTrial::HQPExperimentalScoringEnabled() {
- return variations::GetVariationParamValue(
- kBundledExperimentFieldTrialName,
- kHQPExperimentalScoringEnabledParam) == "true";
-}
-
-std::string OmniboxFieldTrial::HQPExperimentalScoringBuckets() {
- if (!HQPExperimentalScoringEnabled())
- return "";
-
- return variations::GetVariationParamValue(
- kBundledExperimentFieldTrialName,
- kHQPExperimentalScoringBucketsParam);
-}
-
-float OmniboxFieldTrial::HQPExperimentalTopicalityThreshold() {
- if (!HQPExperimentalScoringEnabled())
- return -1;
-
- std::string topicality_threhold_str =
- variations::GetVariationParamValue(
- kBundledExperimentFieldTrialName,
- kHQPExperimentalScoringTopicalityThresholdParam);
-
- double topicality_threshold;
- if (!base::StringToDouble(topicality_threhold_str, &topicality_threshold))
- return -1;
-
- return static_cast<float>(topicality_threshold);
-}
-
bool OmniboxFieldTrial::HQPAllowMatchInTLDValue() {
return variations::GetVariationParamValue(
kBundledExperimentFieldTrialName,
@@ -372,6 +341,43 @@ void OmniboxFieldTrial::GetSuggestPollingStrategy(bool* from_last_keystroke,
}
}
+bool OmniboxFieldTrial::HQPExperimentalScoringEnabled() {
+ return variations::GetVariationParamValue(
+ kBundledExperimentFieldTrialName,
+ kHQPExperimentalScoringEnabledParam) == "true";
+}
+
+std::string OmniboxFieldTrial::HQPExperimentalScoringBuckets() {
+ if (!HQPExperimentalScoringEnabled())
+ return "";
+
+ return variations::GetVariationParamValue(
+ kBundledExperimentFieldTrialName,
+ kHQPExperimentalScoringBucketsParam);
+}
+
+float OmniboxFieldTrial::HQPExperimentalTopicalityThreshold() {
+ if (!HQPExperimentalScoringEnabled())
+ return -1;
+
+ std::string topicality_threhold_str =
+ variations::GetVariationParamValue(
+ kBundledExperimentFieldTrialName,
+ kHQPExperimentalScoringTopicalityThresholdParam);
+
+ double topicality_threshold;
+ if (!base::StringToDouble(topicality_threhold_str, &topicality_threshold))
+ return -1;
+
+ return static_cast<float>(topicality_threshold);
+}
+
+bool OmniboxFieldTrial::HQPFixFrequencyScoringBugs() {
+ return variations::GetVariationParamValue(
+ kBundledExperimentFieldTrialName,
+ kHQPFixFrequencyScoringBugsRule) == "true";
+}
+
const char OmniboxFieldTrial::kBundledExperimentFieldTrialName[] =
"OmniboxBundledExperimentV1";
const char OmniboxFieldTrial::kDisableProvidersRule[] = "DisableProviders";
@@ -396,6 +402,8 @@ OmniboxFieldTrial::kMeasureSuggestPollingDelayFromLastKeystrokeRule[] =
"MeasureSuggestPollingDelayFromLastKeystroke";
const char OmniboxFieldTrial::kSuggestPollingDelayMsRule[] =
"SuggestPollingDelayMs";
+const char OmniboxFieldTrial::kHQPFixFrequencyScoringBugsRule[] =
+ "HQPFixFrequencyScoringBugs";
const char OmniboxFieldTrial::kHUPNewScoringEnabledParam[] =
"HUPExperimentalScoringEnabled";
« no previous file with comments | « components/omnibox/omnibox_field_trial.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698