Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1009943004: Remove dependency on //components/feedback on iOS (Closed)

Created:
5 years, 9 months ago by sdefresne
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency on //components/feedback on iOS iOS does not use //components/feedback to report feedback so remove the unused dependencies. BUG=None Committed: https://crrev.com/bbf563cae4aec3a398d91771ad9208321cd67e20 Cr-Commit-Position: refs/heads/master@{#320891}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -20 lines) Patch
M chrome/browser/BUILD.gn View 1 3 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 3 chunks +1 line, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 3 chunks +1 line, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 3 chunks +1 line, -2 lines 0 comments Download
M components/components.gyp View 1 2 chunks +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 7 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
sdefresne
This is a reland of https://codereview.chromium.org/954943004/ now that http://crbug.com/462352 has been fixed.
5 years, 9 months ago (2015-03-16 15:25:07 UTC) #2
Mark Mentovai
LGTM
5 years, 9 months ago (2015-03-16 15:27:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009943004/1
5 years, 9 months ago (2015-03-16 16:52:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/49914)
5 years, 9 months ago (2015-03-16 17:11:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009943004/20001
5 years, 9 months ago (2015-03-16 18:19:06 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/49955)
5 years, 9 months ago (2015-03-16 18:56:56 UTC) #12
sdefresne
+jochen for OWNERS review
5 years, 9 months ago (2015-03-16 21:44:45 UTC) #14
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-17 10:32:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009943004/20001
5 years, 9 months ago (2015-03-17 10:33:44 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 11:09:20 UTC) #18
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 11:10:24 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bbf563cae4aec3a398d91771ad9208321cd67e20
Cr-Commit-Position: refs/heads/master@{#320891}

Powered by Google App Engine
This is Rietveld 408576698