Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8738)

Unified Diff: chrome/chrome_browser.gypi

Issue 1009943004: Remove dependency on //components/feedback on iOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_browser.gypi
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index ea84ca6c8c23b76c6cece0f3da524a833fd7cdcb..125ae446c247626e68ad537993a3453696c74576 100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -2924,7 +2924,6 @@
'../components/components.gyp:enhanced_bookmarks',
'../components/components.gyp:favicon_base',
'../components/components.gyp:favicon_core_browser',
- '../components/components.gyp:feedback_component',
'../components/components.gyp:gcm_driver',
'../components/components.gyp:google_core_browser',
'../components/components.gyp:handoff',
@@ -3402,6 +3401,7 @@
}, { # OS!="android" and OS!="ios"
'sources': [ '<@(chrome_browser_non_mobile_sources)' ],
'dependencies': [
+ '../components/components.gyp:feedback_component',
'../device/core/core.gyp:device_core',
'../device/usb/usb.gyp:device_usb',
'../net/net.gyp:net_browser_services',
@@ -3419,7 +3419,6 @@
'chrome_browser_jni_headers',
],
'dependencies!': [
- '../components/components.gyp:feedback_component',
'../components/components.gyp:storage_monitor',
'../components/components.gyp:web_modal',
'../third_party/libaddressinput/libaddressinput.gyp:libaddressinput',
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698