Move chrome specific code from platform/audio/chromium to platform/audio

Move chrome specific code from platform/audio/chromium to platform/audio
    
Re-factors chromium code to parent folder platform/audio.
Remove AudioDestination.h abstract class and rename AudioDestinationChromium* to AudioDestination*
Android code is moved to dedicated android folder.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164305

[atreat, 2013-12-19 16:04:23]

Seems unnecessary to move the android file into a specific android subdirectory
when it is suffixed with 'Android.cpp'  Also, you have a typo in your commit
message.

https://codereview.chromium.org/100993004/diff/20001/Source/platform/audio/Au...
File Source/platform/audio/AudioDestination.h (right):

https://codereview.chromium.org/100993004/diff/20001/Source/platform/audio/Au...
Source/platform/audio/AudioDestination.h:33: #include
"platform/audio/AudioDestination.h"
Please remove self-referential include.

[maheshkk, 2013-12-19 16:53:08]

On 2013/12/19 16:04:23, atreat wrote:
> Seems unnecessary to move the android file into a specific android
subdirectory
> when it is suffixed with 'Android.cpp'  

FFTFrame class needs platform specific implementation, we already have
 - mac/FFTFrameMac.cpp
 - ipp/FFTFrameIPP
 - ffmpeg/FFTFrameFFMPEG
 - and now android/FFTFrameAndroid 
 - FFTFrameStub (for everything else)
 
So either we move all of above to parent folder or leave them in platform
specific folder.

> Also, you have a typo in your commit
> message.

Done. 

> 
>
https://codereview.chromium.org/100993004/diff/20001/Source/platform/audio/Au...
> File Source/platform/audio/AudioDestination.h (right):
> 
>
https://codereview.chromium.org/100993004/diff/20001/Source/platform/audio/Au...
> Source/platform/audio/AudioDestination.h:33: #include
> "platform/audio/AudioDestination.h"
> Please remove self-referential include.

done.

[maheshkk, 2013-12-23 18:35:28]

please review

[eseidel, 2013-12-23 18:45:28]

I don't know who does audio now that Chris is gone.

[Raymond Toy (Google), 2013-12-23 19:34:48]

On 2013/12/23 18:48:10, eseidel wrote:

I think the abstraction was needed to support safari/mac, gtk, etc, backends in
webkit.  Presumably, we will never support anything other than Chrome's audio
backend from now on?

Having said that, lgtm, but you may want to have kbr@ take a look too.

[Ken Russell (switch to Gerrit), 2013-12-23 21:46:56]

lgtm

[commit-bot: I haz the power, 2013-12-23 21:52:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/100993004/30001

[maheshkk, 2013-12-23 21:53:20]

On 2013/12/23 21:46:56, Ken Russell wrote:
> lgtm

Thank you for reviewing rtoy and kbr. Thanks eseidel for following this up.

[commit-bot: I haz the power, 2013-12-23 22:45:33]

Change committed as 164305