Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1009923002: Don't allow <stop> as layout tree child of <svg> or <g> (Closed)

Created:
5 years, 9 months ago by fs
Modified:
5 years, 9 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, Dominik Röttsches, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't allow <stop> as layout tree child of <svg> or <g> LayoutSVGGradientStop would be allowed as children of <svg>, <g> and other containers which could trigger asserts and wreck havoc. BUG=466937 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191932

Patch Set 1 #

Total comments: 2

Patch Set 2 : Content model tests for linear/radialGradient. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2 lines) Patch
A LayoutTests/svg/custom/gradient-stop-outside-gradient.html View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/gradient-stop-outside-gradient-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/svg/dom/content-model.html View 1 1 chunk +22 lines, -0 lines 0 comments Download
M LayoutTests/svg/dom/content-model-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGModelObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
fs
5 years, 9 months ago (2015-03-16 13:02:41 UTC) #2
Erik Dahlström (inactive)
lgtm w/ nit https://codereview.chromium.org/1009923002/diff/1/LayoutTests/svg/dom/content-model.html File LayoutTests/svg/dom/content-model.html (right): https://codereview.chromium.org/1009923002/diff/1/LayoutTests/svg/dom/content-model.html#newcode104 LayoutTests/svg/dom/content-model.html:104: validateTag('g', [ might be good to ...
5 years, 9 months ago (2015-03-16 13:58:46 UTC) #3
fs
https://codereview.chromium.org/1009923002/diff/1/LayoutTests/svg/dom/content-model.html File LayoutTests/svg/dom/content-model.html (right): https://codereview.chromium.org/1009923002/diff/1/LayoutTests/svg/dom/content-model.html#newcode104 LayoutTests/svg/dom/content-model.html:104: validateTag('g', [ On 2015/03/16 13:58:46, Erik Dahlström wrote: > ...
5 years, 9 months ago (2015-03-16 14:20:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009923002/20001
5 years, 9 months ago (2015-03-16 14:21:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009923002/20001
5 years, 9 months ago (2015-03-16 14:21:30 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 15:54:16 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191932

Powered by Google App Engine
This is Rietveld 408576698