Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: Source/core/layout/svg/LayoutSVGRoot.cpp

Issue 1009923002: Don't allow <stop> as layout tree child of <svg> or <g> (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Content model tests for linear/radialGradient. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/layout/svg/LayoutSVGModelObject.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007, 2008, 2009 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007, 2008, 2009 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2009 Google, Inc. 5 * Copyright (C) 2009 Google, Inc.
6 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 // Box decorations may have appeared/disappeared - recompute status. 229 // Box decorations may have appeared/disappeared - recompute status.
230 m_hasBoxDecorationBackground = calculateHasBoxDecorations(); 230 m_hasBoxDecorationBackground = calculateHasBoxDecorations();
231 } 231 }
232 232
233 LayoutReplaced::styleDidChange(diff, oldStyle); 233 LayoutReplaced::styleDidChange(diff, oldStyle);
234 SVGResourcesCache::clientStyleChanged(this, diff, styleRef()); 234 SVGResourcesCache::clientStyleChanged(this, diff, styleRef());
235 } 235 }
236 236
237 bool LayoutSVGRoot::isChildAllowed(LayoutObject* child, const LayoutStyle&) cons t 237 bool LayoutSVGRoot::isChildAllowed(LayoutObject* child, const LayoutStyle&) cons t
238 { 238 {
239 return child->isSVG() && !(child->isSVGInline() || child->isSVGInlineText()) ; 239 return child->isSVG() && !(child->isSVGInline() || child->isSVGInlineText() || child->isSVGGradientStop());
240 } 240 }
241 241
242 void LayoutSVGRoot::addChild(LayoutObject* child, LayoutObject* beforeChild) 242 void LayoutSVGRoot::addChild(LayoutObject* child, LayoutObject* beforeChild)
243 { 243 {
244 LayoutReplaced::addChild(child, beforeChild); 244 LayoutReplaced::addChild(child, beforeChild);
245 SVGResourcesCache::clientWasAddedToTree(child, child->styleRef()); 245 SVGResourcesCache::clientWasAddedToTree(child, child->styleRef());
246 246
247 bool shouldIsolateDescendants = (child->isBlendingAllowed() && child->style( )->hasBlendMode()) || child->hasNonIsolatedBlendingDescendants(); 247 bool shouldIsolateDescendants = (child->isBlendingAllowed() && child->style( )->hasBlendMode()) || child->hasNonIsolatedBlendingDescendants();
248 if (shouldIsolateDescendants) 248 if (shouldIsolateDescendants)
249 descendantIsolationRequirementsChanged(DescendantIsolationRequired); 249 descendantIsolationRequirementsChanged(DescendantIsolationRequired);
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
425 updateHitTestResult(result, pointInBorderBox); 425 updateHitTestResult(result, pointInBorderBox);
426 if (!result.addNodeToListBasedTestResult(node(), request, locationIn Container, boundsRect)) 426 if (!result.addNodeToListBasedTestResult(node(), request, locationIn Container, boundsRect))
427 return true; 427 return true;
428 } 428 }
429 } 429 }
430 430
431 return false; 431 return false;
432 } 432 }
433 433
434 } 434 }
OLDNEW
« no previous file with comments | « Source/core/layout/svg/LayoutSVGModelObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698