Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 1009903002: Revert of Remove kind field from StackHandler. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove kind field from StackHandler. (patchset #4 id:60001 of https://codereview.chromium.org/1002203002/) Reason for revert: Layout test failure in inspector/sources/debugger/debugger-pause-on-promise-rejection.html Original issue's description: > Remove kind field from StackHandler. > > This makes the Isolate::Throw logic not depend on a prediction of > whether an exception is caught or uncaught. Such a prediction is > inherently undecidable because a finally block can decide between > consuming or re-throwing an exception depending on arbitray control > flow. > > There still is a conservative prediction mechanism in place that > components like the debugger or tracing can use for reporting. > > With this change we can get rid of the StackHandler::kind field, a > pre-requisite to do table-based lookups of exception handlers. > > R=yangguo@chromium.org > > Committed: https://crrev.com/96f79568a926966ebcf0685bf9adc947f4e1fbff > Cr-Commit-Position: refs/heads/master@{#27210} TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/5977ed0203606ab2490a9402a686331b58279117 Cr-Commit-Position: refs/heads/master@{#27215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -156 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/debug.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/debug.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M src/frames.h View 2 chunks +14 lines, -1 line 0 comments Download
M src/frames.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/frames-inl.h View 1 chunk +23 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/isolate.h View 5 chunks +10 lines, -11 lines 0 comments Download
M src/isolate.cc View 9 chunks +108 lines, -124 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
Created Revert of Remove kind field from StackHandler.
5 years, 9 months ago (2015-03-16 11:40:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009903002/1
5 years, 9 months ago (2015-03-16 11:40:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 11:41:31 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 11:41:45 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5977ed0203606ab2490a9402a686331b58279117
Cr-Commit-Position: refs/heads/master@{#27215}

Powered by Google App Engine
This is Rietveld 408576698