Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1009893004: Missing collectMatchingShadowHostRules call from hasAnyMatchingRules. (Closed)

Created:
5 years, 9 months ago by rune
Modified:
5 years, 9 months ago
Reviewers:
esprehn, kochi
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Missing collectMatchingShadowHostRules call from hasAnyMatchingRules. This caused style to be incorrectly shared between two different hosts with different matching for :host([attr]). Regression from https://codereview.chromium.org/789403005 R=kochi@chromium.org BUG=466815 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191947

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
A LayoutTests/fast/dom/shadow/style-sharing-host-attribute.html View 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/style-sharing-host-attribute-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/css/ElementRuleCollector.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
rune
5 years, 9 months ago (2015-03-16 11:54:06 UTC) #1
esprehn
lgtm, good catch.
5 years, 9 months ago (2015-03-16 19:53:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009893004/1
5 years, 9 months ago (2015-03-16 19:55:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=191947
5 years, 9 months ago (2015-03-16 20:56:16 UTC) #6
kochi
5 years, 9 months ago (2015-03-17 02:05:41 UTC) #7
Message was sent while issue was closed. 
On 2015/03/16 20:56:16, I haz the power (commit-bot) wrote:
> Committed patchset #1 (id:1) as
> https://src.chromium.org/viewvc/blink?view=rev&revision=191947

Thanks Rune, belated lgtm.

(and thanks to Elliott, reviewing while I'm sleeping.)

Powered by Google App Engine
This is Rietveld 408576698