Source/core/css/ElementRuleCollector.cpp - Issue 1009893004: Missing collectMatchingShadowHostRules call from hasAnyMatchingRules.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/css/ElementRuleCollector.cpp

Issue 1009893004: Missing collectMatchingShadowHostRules call from hasAnyMatchingRules. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fast/dom/shadow/style-sharing-host-attribute-expected.txt ('k') | no next file » | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)	3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)

4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)	4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)

5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.	5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.

6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>	6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>

7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>	7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>

8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)	8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)

9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.	9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.

10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.	10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.

(...skipping 324 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
335 bool ElementRuleCollector::hasAnyMatchingRules(RuleSet* ruleSet)	335 bool ElementRuleCollector::hasAnyMatchingRules(RuleSet* ruleSet)

336 {	336 {

337 clearMatchedRules();	337 clearMatchedRules();

338	338

339 m_mode = SelectorChecker::SharingRules;	339 m_mode = SelectorChecker::SharingRules;

340 // To check whether a given RuleSet has any rule matching a given element,	340 // To check whether a given RuleSet has any rule matching a given element,

341 // should not see the element's treescope. Because RuleSet has no	341 // should not see the element's treescope. Because RuleSet has no

342 // information about "scope".	342 // information about "scope".

343 int firstRuleIndex = -1, lastRuleIndex = -1;	343 int firstRuleIndex = -1, lastRuleIndex = -1;

344 RuleRange ruleRange(firstRuleIndex, lastRuleIndex);	344 RuleRange ruleRange(firstRuleIndex, lastRuleIndex);

345 collectMatchingRules(MatchRequest(ruleSet), ruleRange);	345 MatchRequest matchRequest(ruleSet);

	346 collectMatchingRules(matchRequest, ruleRange);

	347 collectMatchingShadowHostRules(matchRequest, ruleRange);

346	348

347 return !m_matchedRules.isEmpty();	349 return !m_matchedRules.isEmpty();

348 }	350 }

349	351

350 } // namespace blink	352 } // namespace blink

OLD	NEW