Factor out the QUIC socket reading code into a stand alone QuicPacketReader

Factor out the QUIC socket reading code into a stand alone QuicPacketReader
and share it with both the QuicClientSession and QuicSimpleClient.

BUG=

Committed: https://crrev.com/31ca50f123ae4580d4d681856aec2379aaa39896
Cr-Commit-Position: refs/heads/master@{#321522}

[Ryan Hamilton, 2015-03-19 03:22:31]

rch@chromium.org changed reviewers:
+ rtenneti@chromium.org

[ramant (doing other things), 2015-03-19 19:12:36]

LGTM. Thanks for making this change (very cool).

https://codereview.chromium.org/1009803003/diff/20001/net/quic/quic_packet_re...
File net/quic/quic_packet_reader.cc (right):

https://codereview.chromium.org/1009803003/diff/20001/net/quic/quic_packet_re...
net/quic/quic_packet_reader.cc:1: 
nit: extra blank line.

https://codereview.chromium.org/1009803003/diff/20001/net/quic/quic_packet_re...
net/quic/quic_packet_reader.cc:58: if (result == 0)
overly nit: this was there in the old code. At line# 29 we are following
internal source convention and line#58 we are following chromium style. it is
your call.

https://codereview.chromium.org/1009803003/diff/20001/net/quic/quic_packet_re...
net/quic/quic_packet_reader.cc:71: // ProcessUdpPacket might result in |this|
being deleted, so we
nit: Should we change "ProcessUdpPacket" to "OnPacket" and consider fixing the
comment (about weak pointer).

https://codereview.chromium.org/1009803003/diff/20001/net/quic/quic_packet_re...
File net/quic/quic_packet_reader.h (right):

https://codereview.chromium.org/1009803003/diff/20001/net/quic/quic_packet_re...
net/quic/quic_packet_reader.h:1: // Copyright (c) 2012 The Chromium Authors. All
rights reserved.
nit: it is surprising that git cl upload (or commit) didn't change to 2015.

https://codereview.chromium.org/1009803003/diff/20001/net/quic/quic_packet_re...
net/quic/quic_packet_reader.h:22: virtual ~Visitor(){};
overly nit: " ~Visitor(){};" -> " ~Visitor() {};"?

[Ryan Hamilton, 2015-03-19 19:54:49]

Thanks, Raman!

https://codereview.chromium.org/1009803003/diff/20001/net/quic/quic_packet_re...
File net/quic/quic_packet_reader.cc (right):

https://codereview.chromium.org/1009803003/diff/20001/net/quic/quic_packet_re...
net/quic/quic_packet_reader.cc:1: 
On 2015/03/19 19:12:35, ramant wrote:
> nit: extra blank line.

Done.

https://codereview.chromium.org/1009803003/diff/20001/net/quic/quic_packet_re...
net/quic/quic_packet_reader.cc:58: if (result == 0)
On 2015/03/19 19:12:35, ramant wrote:
> overly nit: this was there in the old code. At line# 29 we are following
> internal source convention and line#58 we are following chromium style. it is
> your call.

Good catch. I'll fix line 29 to use chrome style since this is chrome-specific.
Cool?

https://codereview.chromium.org/1009803003/diff/20001/net/quic/quic_packet_re...
net/quic/quic_packet_reader.cc:71: // ProcessUdpPacket might result in |this|
being deleted, so we
On 2015/03/19 19:12:35, ramant wrote:
> nit: Should we change "ProcessUdpPacket" to "OnPacket" and consider fixing the
> comment (about weak pointer).

Thanks, again. I should have just removed that comment completely.

https://codereview.chromium.org/1009803003/diff/20001/net/quic/quic_packet_re...
File net/quic/quic_packet_reader.h (right):

https://codereview.chromium.org/1009803003/diff/20001/net/quic/quic_packet_re...
net/quic/quic_packet_reader.h:1: // Copyright (c) 2012 The Chromium Authors. All
rights reserved.
On 2015/03/19 19:12:35, ramant wrote:
> nit: it is surprising that git cl upload (or commit) didn't change to 2015.

I *thought* we had something that fixed this automatically? Grr.  DOne.

https://codereview.chromium.org/1009803003/diff/20001/net/quic/quic_packet_re...
net/quic/quic_packet_reader.h:22: virtual ~Visitor(){};
On 2015/03/19 19:12:35, ramant wrote:
> overly nit: " ~Visitor(){};" -> " ~Visitor() {};"?

WHoops! Fixed.

[ramant (doing other things), 2015-03-19 20:53:47]

lgtm

Thanks much Ryan.

[Ryan Hamilton, 2015-03-19 23:57:54]

Patchset #4 (id:60001) has been deleted

[Ryan Hamilton, 2015-03-19 23:58:59]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-03-19 23:59:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
rtenneti@chromium.org
Link to the patchset: https://codereview.chromium.org/1009803003/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2015-03-19 23:59:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1009803003/80001

[Ryan Hamilton, 2015-03-20 00:00:40]

The CQ bit was unchecked by rch@chromium.org

[Ryan Hamilton, 2015-03-20 02:33:20]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2015-03-20 02:33:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1009803003/80001

[commit-bot: I haz the power, 2015-03-20 03:29:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-20 03:29:43]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Ryan Hamilton, 2015-03-20 03:46:37]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-03-20 03:46:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
rtenneti@chromium.org
Link to the patchset: https://codereview.chromium.org/1009803003/#ps100001
(title: "more export")

[commit-bot: I haz the power, 2015-03-20 03:46:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1009803003/100001

[commit-bot: I haz the power, 2015-03-20 05:51:13]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-03-20 05:52:05]

Patchset 5 (id:??) landed as
https://crrev.com/31ca50f123ae4580d4d681856aec2379aaa39896
Cr-Commit-Position: refs/heads/master@{#321522}