Factor out the QUIC socket reading code into a stand alone QuicPacketReader

net/quic/quic_packet_reader.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.

[ramant (doing other things), 2015/03/19 19:12:35]

nit: it is surprising that git cl upload (or commit) didn't change to 2015.

[Ryan Hamilton, 2015/03/19 19:54:49]

I *thought* we had something that fixed this automatically? Grr.  DOne.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+
+#ifndef NET_QUIC_QUIC_PACKET_READER_H_
+#define NET_QUIC_QUIC_PACKET_READER_H_
+
+#include "base/memory/weak_ptr.h"
+#include "net/base/io_buffer.h"
+#include "net/base/net_export.h"
+#include "net/base/net_log.h"
+#include "net/quic/quic_protocol.h"
+#include "net/udp/datagram_client_socket.h"
+
+namespace net {
+
+class NET_EXPORT_PRIVATE QuicPacketReader {
+ public:
+  class Visitor {
+   public:
+    virtual ~Visitor(){};

[ramant (doing other things), 2015/03/19 19:12:35]

overly nit: " ~Visitor(){};" -> " ~Visitor() {};"?

[Ryan Hamilton, 2015/03/19 19:54:49]

WHoops! Fixed.

+    virtual void OnReadError(int result) = 0;
+    virtual bool OnPacket(const QuicEncryptedPacket& packet,
+                          IPEndPoint local_address,
+                          IPEndPoint peer_address) = 0;
+  };
+
+  QuicPacketReader(DatagramClientSocket* socket,
+                   Visitor* visitor,
+                   const BoundNetLog& net_log);
+  ~QuicPacketReader();
+
+  // Causes the QuicConnectionHelper to start reading from the socket
+  // and passing the data along to the QuicConnection.
+  void StartReading();
+
+ private:
+  // A completion callback invoked when a read completes.
+  void OnReadComplete(int result);
+
+  DatagramClientSocket* socket_;
+  Visitor* visitor_;
+  bool read_pending_;
+  int num_packets_read_;
+  scoped_refptr<IOBufferWithSize> read_buffer_;
+  BoundNetLog net_log_;
+
+  base::WeakPtrFactory<QuicPacketReader> weak_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(QuicPacketReader);
+};
+
+}  // namespace net
+
+#endif  // NET_QUIC_QUIC_PACKET_READER_H_