LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments.html - Issue 100963003: Use V8TRYCATCH_FOR_V8STRINGRESOURCE() macro instead of toCoreStringWithUndefinedOrNullCheck()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments.html

Issue 100963003: Use V8TRYCATCH_FOR_V8STRINGRESOURCE() macro instead of toCoreStringWithUndefinedOrNullCheck() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take Yury's feedback into consideration Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments.html

diff --git a/LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments.html b/LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments.html

new file mode 100644

index 0000000000000000000000000000000000000000..04ca06cc303de3301e5fb1af1ff1d0f52497c96f

--- /dev/null

+++ b/LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments.html

@@ -0,0 +1,20 @@

+<html>

+<head>

+<script src="../../../resources/js-test.js"></script>

+</head>

+<body>

+<script>

+description("Checks that passing invalid strings to window.showModalDialog() is properly handled.");

+if (window.testRunner)

+ testRunner.setCanOpenWindows();

+var nonConvertibleToString = { toString: function() { throw "Exception in toString()"; } };

+var newWindow = null;

+shouldThrow("newWindow = window.showModalDialog(nonConvertibleToString)", "'Exception in toString()'");

+shouldBeNull("newWindow");

+shouldThrow("newWindow = window.showModalDialog('about:blank', '', nonConvertibleToString)", "'Exception in toString()'");

+shouldBeNull("newWindow");

+</script>

+</body>

+</html>

« no previous file with comments | « no previous file | LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments-expected.txt » ('j') | no next file with comments »