LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments.html - Issue 100963003: Use V8TRYCATCH_FOR_V8STRINGRESOURCE() macro instead of toCoreStringWithUndefinedOrNullCheck()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments.html

Issue 100963003: Use V8TRYCATCH_FOR_V8STRINGRESOURCE() macro instead of toCoreStringWithUndefinedOrNullCheck() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take Yury's feedback into consideration Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../../../resources/js-test.js"></script>

	4 </head>

	5 <body>

	6 <script>

	7 description("Checks that passing invalid strings to window.showModalDialog() is properly handled.");

	8

	9 if (window.testRunner)

	10 testRunner.setCanOpenWindows();

	11

	12 var nonConvertibleToString = { toString: function() { throw "Exception in toStri ng()"; } };

	13 var newWindow = null;

	14 shouldThrow("newWindow = window.showModalDialog(nonConvertibleToString)", "'Exce ption in toString()'");

	15 shouldBeNull("newWindow");

	16 shouldThrow("newWindow = window.showModalDialog('about:blank', '', nonConvertibl eToString)", "'Exception in toString()'");

	17 shouldBeNull("newWindow");

	18 </script>

	19 </body>

	20 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments-expected.txt » ('j') | no next file with comments »