src/objects-inl.h - Issue 1009603003: Add debug checks to catch crashes with WeakCell::cast().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 1009603003: Add debug checks to catch crashes with WeakCell::cast(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index 11294011a0557ee339603308c9adb65891e41b44..ae504dc3e3963e5819c4344796c3520f66ba0c97 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -2349,6 +2349,7 @@ void FixedDoubleArray::FillWithHoles(int from, int to) {

Object* WeakFixedArray::Get(int index) const {

Object* raw = FixedArray::cast(this)->get(index + kFirstIndex);

if (raw->IsSmi()) return raw;

+ DCHECK(raw->IsWeakCell());

return WeakCell::cast(raw)->value();

}

« no previous file with comments | « src/objects.cc ('k') | src/transitions.h » ('j') | no next file with comments »