src/transitions.h - Issue 1009603003: Add debug checks to catch crashes with WeakCell::cast().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/transitions.h

Issue 1009603003: Add debug checks to catch crashes with WeakCell::cast(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/transitions.h

diff --git a/src/transitions.h b/src/transitions.h

index 648559ba4cd2652fd836b691e81c9fbb226a48d9..1cb91a222e6fec33133c3c3fd060102cb01a3750 100644

--- a/src/transitions.h

+++ b/src/transitions.h

@@ -68,6 +68,7 @@ class TransitionArray: public FixedArray {

}

static inline Map* GetSimpleTransition(Object* raw_transition) {

DCHECK(IsSimpleTransition(raw_transition));

+ DCHECK(raw_transition->IsWeakCell());

return Map::cast(WeakCell::cast(raw_transition)->value());

}

static inline bool IsFullTransitionArray(Object* raw_transitions) {

« no previous file with comments | « src/objects-inl.h ('k') | src/type-feedback-vector.cc » ('j') | no next file with comments »