content/browser/service_worker/service_worker_version.cc - Issue 1009583004: Add UMA histograms and logging for bad IPC message handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 1009583004: Add UMA histograms and logging for bad IPC message handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: actions.xml claims to be pretty printed Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac.mm ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version.cc

diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc

index 0682c5a81144bde859d5ebea1b03b1a3448f7e5e..b66de89d7b39c8c659293f3e73946562b24875ea 100644

--- a/content/browser/service_worker/service_worker_version.cc

+++ b/content/browser/service_worker/service_worker_version.cc

@@ -11,6 +11,7 @@

#include "base/strings/string16.h"

#include "base/strings/utf_string_conversions.h"

#include "base/time/time.h"

+#include "content/browser/bad_message.h"

#include "content/browser/child_process_security_policy_impl.h"

#include "content/browser/message_port_message_filter.h"

#include "content/browser/message_port_service.h"

@@ -248,8 +249,10 @@ void KillEmbeddedWorkerProcess(int process_id, ResultCode code) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

RenderProcessHost* render_process_host =

RenderProcessHost::FromID(process_id);

- if (render_process_host->GetHandle() != base::kNullProcessHandle)

- render_process_host->ReceivedBadMessage();

+ if (render_process_host->GetHandle() != base::kNullProcessHandle) {

+ bad_message::ReceivedBadMessage(render_process_host,

+ bad_message::SERVICE_WORKER_BAD_URL);

+ }

}

void ClearTick(base::TimeTicks* time) {

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac.mm ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »