Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1009583004: Add UMA histograms and logging for bad IPC message handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: actions.xml claims to be pretty printed Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_version.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 9b4875c1d9b14461c26486ef4fd76015160907e6..a9acc7c47ff6789891c66f97adacdfceb753158d 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -20,6 +20,7 @@
#include "base/trace_event/trace_event.h"
#include "content/browser/accessibility/accessibility_mode_helper.h"
#include "content/browser/accessibility/browser_accessibility_state_impl.h"
+#include "content/browser/bad_message.h"
#include "content/browser/browser_plugin/browser_plugin_embedder.h"
#include "content/browser/browser_plugin/browser_plugin_guest.h"
#include "content/browser/child_process_security_policy_impl.h"
@@ -640,8 +641,8 @@ bool WebContentsImpl::OnMessageReceived(RenderViewHost* render_view_host,
bool WebContentsImpl::HasValidFrameSource() {
if (!render_frame_message_source_) {
DCHECK(render_view_message_source_);
- RecordAction(base::UserMetricsAction("BadMessageTerminate_WC"));
- GetRenderProcessHost()->ReceivedBadMessage();
+ bad_message::ReceivedBadMessage(GetRenderProcessHost(),
+ bad_message::WC_INVALID_FRAME_SOURCE);
return false;
}
« no previous file with comments | « content/browser/service_worker/service_worker_version.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698