content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 1009583004: Add UMA histograms and logging for bad IPC message handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 1009583004: Add UMA histograms and logging for bad IPC message handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: actions.xml claims to be pretty printed Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | content/browser/service_worker/service_worker_version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index 86f5a774225371db85fd1cc8dbf5f64a44489c0e..7f0cb00b2ee7c1b378ce5c85b43fe88bab9c76ab 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -28,6 +28,7 @@

#include "base/trace_event/trace_event.h"

#import "content/browser/accessibility/browser_accessibility_cocoa.h"

#include "content/browser/accessibility/browser_accessibility_manager_mac.h"

+#include "content/browser/bad_message.h"

#import "content/browser/cocoa/system_hotkey_helper_mac.h"

#import "content/browser/cocoa/system_hotkey_map.h"

#include "content/browser/compositor/resize_lock.h"

@@ -52,7 +53,6 @@

#include "content/public/browser/notification_types.h"

#include "content/public/browser/render_widget_host_view_frame_subscriber.h"

#import "content/public/browser/render_widget_host_view_mac_delegate.h"

-#include "content/public/browser/user_metrics.h"

#include "content/public/browser/web_contents.h"

#include "skia/ext/platform_canvas.h"

#include "skia/ext/skia_utils_mac.h"

@@ -1475,9 +1475,8 @@ void RenderWidgetHostViewMac::OnSwapCompositorFrame(

frame->metadata.latency_info);

} else {

DLOG(ERROR) << "Received unexpected frame type.";

- RecordAction(

- base::UserMetricsAction("BadMessageTerminate_UnexpectedFrameType"));

- render_widget_host_->GetProcess()->ReceivedBadMessage();

+ bad_message::ReceivedBadMessage(render_widget_host_->GetProcess(),

+ bad_message::RWHVM_UNEXPECTED_FRAME_TYPE);

}