content/browser/renderer_host/render_widget_host_view_aura.cc - Issue 1009583004: Add UMA histograms and logging for bad IPC message handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 1009583004: Add UMA histograms and logging for bad IPC message handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: actions.xml claims to be pretty printed Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_impl.cc ('k') | content/browser/renderer_host/render_widget_host_view_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_aura.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc

index 874e34ba3b18e6b0eec4ecc14f8562f14e81173c..94469af5dc9f72824c096cd103e14aa4548f0c17 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc

@@ -20,6 +20,7 @@

#include "cc/trees/layer_tree_settings.h"

#include "content/browser/accessibility/browser_accessibility_manager.h"

#include "content/browser/accessibility/browser_accessibility_state_impl.h"

+#include "content/browser/bad_message.h"

#include "content/browser/frame_host/frame_tree.h"

#include "content/browser/frame_host/frame_tree_node.h"

#include "content/browser/frame_host/render_frame_host_impl.h"

@@ -1075,9 +1076,8 @@ void RenderWidgetHostViewAura::OnSwapCompositorFrame(

if (frame->software_frame_data) {

DLOG(ERROR) << "Unable to use software frame in aura";

- RecordAction(

- base::UserMetricsAction("BadMessageTerminate_SharedMemoryAura"));

- host_->GetProcess()->ReceivedBadMessage();

+ bad_message::ReceivedBadMessage(host_->GetProcess(),

+ bad_message::RWHVA_SHARED_MEMORY);

return;

}