content/public/browser/render_process_host.h - Issue 1009583004: Add UMA histograms and logging for bad IPC message handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/render_process_host.h

Issue 1009583004: Add UMA histograms and logging for bad IPC message handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix mac Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/browser_child_process_host_impl.cc ('K') | « content/content_browser.gypi ('k') | content/public/test/mock_render_process_host.h » ('j') | extensions/browser/bad_message.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/render_process_host.h

diff --git a/content/public/browser/render_process_host.h b/content/public/browser/render_process_host.h

index bb774988a2b83a2e8d0ccc6fd7ecfcdf8624c8d2..119a923521a48300fc3f74eb943f0f2609c438ca 100644

--- a/content/public/browser/render_process_host.h

+++ b/content/public/browser/render_process_host.h

@@ -88,8 +88,11 @@ class CONTENT_EXPORT RenderProcessHost : public IPC::Sender,

virtual void AddObserver(RenderProcessHostObserver* observer) = 0;

virtual void RemoveObserver(RenderProcessHostObserver* observer) = 0;

- // Called when a received message cannot be decoded.

- virtual void ReceivedBadMessage() = 0;

+ // Called when a received message cannot be decoded. Terminates the renderer.

Charlie Reis 2015/03/18 21:37:51 Emphasize up front that most callers should not ca

James Cook 2015/03/18 22:19:44 Done.

+ // Most embedders should use a wrapper method to log an error and record

+ // statistics before calling this method. The recommended name for the

+ // wrapper is ReceivedBadMessage().

+ virtual void ShutdownForBadMessage() = 0;

// Track the count of visible widgets. Called by listeners to register and

// unregister visibility.