Add UMA histograms and logging for bad IPC message handling

content/public/browser/render_process_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_RENDER_PROCESS_HOST_H_
 #define CONTENT_PUBLIC_BROWSER_RENDER_PROCESS_HOST_H_
 
 #include <list>
 
 #include "base/basictypes.h"
@@ skipping 70 matching lines @@
   // listeners own it any more, it will delete itself.
   virtual void AddRoute(int32 routing_id, IPC::Listener* listener) = 0;
   virtual void RemoveRoute(int32 routing_id) = 0;
 
   // Add and remove observers for lifecycle events. The order in which
   // notifications are sent to observers is undefined. Observers must be sure to
   // remove the observer before they go away.
   virtual void AddObserver(RenderProcessHostObserver* observer) = 0;
   virtual void RemoveObserver(RenderProcessHostObserver* observer) = 0;
 
-  // Called when a received message cannot be decoded.
-  virtual void ReceivedBadMessage() = 0;
+  // Called when a received message cannot be decoded. Terminates the renderer.

[Charlie Reis, 2015/03/18 21:37:51]

Emphasize up front that most callers should not call this directly, but rather
bad_message::ReceivedBadMessage (or equivalent methods outside content).

[James Cook, 2015/03/18 22:19:44]

Done.

+  // Most embedders should use a wrapper method to log an error and record
+  // statistics before calling this method. The recommended name for the
+  // wrapper is ReceivedBadMessage().
+  virtual void ShutdownForBadMessage() = 0;
 
   // Track the count of visible widgets. Called by listeners to register and
   // unregister visibility.
   virtual void WidgetRestored() = 0;
   virtual void WidgetHidden() = 0;
   virtual int VisibleWidgetCount() const = 0;
 
   // Indicates whether the current RenderProcessHost is associated with an
   // isolated guest renderer process. Not all guest renderers are created equal.
   // A guest, as indicated by BrowserPluginGuest::IsGuest, may coexist with
@@ skipping 229 matching lines @@
   static void SetMaxRendererProcessCount(size_t count);
 
   // Returns the current maximum number of renderer process hosts kept by the
   // content module.
   static size_t GetMaxRendererProcessCount();
 };
 
 }  // namespace content.
 
 #endif  // CONTENT_PUBLIC_BROWSER_RENDER_PROCESS_HOST_H_