extensions/browser/extension_host.cc - Issue 1009583004: Add UMA histograms and logging for bad IPC message handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_host.cc

Issue 1009583004: Add UMA histograms and logging for bad IPC message handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_process_host_impl.cc ('K') | « extensions/browser/blob_holder.cc ('k') | extensions/browser/guest_view/extension_options/extension_options_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/extension_host.cc

diff --git a/extensions/browser/extension_host.cc b/extensions/browser/extension_host.cc

index bbf51ef4913b41b8d784b07c8eae28e7ed6eebad..45a4dc0d199dd882af11f38bdcfa734c1ac86058 100644

--- a/extensions/browser/extension_host.cc

+++ b/extensions/browser/extension_host.cc

@@ -10,6 +10,7 @@

#include "base/profiler/scoped_tracker.h"

#include "base/strings/string_util.h"

#include "base/strings/utf_string_conversions.h"

+#include "content/public/browser/bad_message.h"

#include "content/public/browser/browser_context.h"

#include "content/public/browser/content_browser_client.h"

#include "content/public/browser/native_web_keyboard_event.h"

@@ -367,7 +368,8 @@ void ExtensionHost::OnEventAck(int event_id) {

DCHECK(render_process_host());

LOG(ERROR) << "Killing renderer for extension " << extension_id() << " for "

<< "sending an EventAck message with a bad event id.";

- render_process_host()->ReceivedBadMessage();

+ render_process_host()->ReceivedBadMessage(

+ content::BadMessage::EH_BAD_EVENT_ID);

}