extensions/browser/blob_holder.cc - Issue 1009583004: Add UMA histograms and logging for bad IPC message handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/blob_holder.cc

Issue 1009583004: Add UMA histograms and logging for bad IPC message handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_process_host_impl.cc ('K') | « content/public/test/mock_render_process_host.cc ('k') | extensions/browser/extension_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/blob_holder.cc

diff --git a/extensions/browser/blob_holder.cc b/extensions/browser/blob_holder.cc

index f0146cdff07aa3f67b2725f252a0050be9514d09..94942f799609dfe565330927623482cb83a725a1 100644

--- a/extensions/browser/blob_holder.cc

+++ b/extensions/browser/blob_holder.cc

@@ -8,6 +8,7 @@

#include <utility>

#include "base/logging.h"

+#include "content/public/browser/bad_message.h"

#include "content/public/browser/blob_handle.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/render_process_host.h"

@@ -77,7 +78,8 @@ void BlobHolder::DropBlobs(const std::vector<std::string>& blob_uuids) {

} else {

DLOG(ERROR) << "Tried to release a Blob we don't have ownership to."

<< "UUID: " << *uuid_it;

- render_process_host_->ReceivedBadMessage();

+ render_process_host_->ReceivedBadMessage(

+ content::BadMessage::BH_BLOB_NOT_OWNED);

}